Use piece values for 'Gloss of danger '#152
Use piece values for 'Gloss of danger '#152marcin-rzeznicki wants to merge 3 commits intobenini:githubfrom
Conversation
|
I'm not sure if this is an improvement. |
3f1fcb9 to
644669a
Compare
|
I see your point. What might be better than this, is to mix these two: red seems to work OK, it is more or less what Chessbase does; but in the case of "not red" I could additionally count the number of defenders (similar to what the previous implementation does) to distinguish it between 'yellow' and 'green'. Does it make sense to you? |
|
You're right, excellent example. OK, I'll revamp it accordingly |
f96d38b to
404bda3
Compare

See #139
This PR modifies the 'gloss of danger' feature to use relative piece values when showing the danger level
Because a picture is worth thousand words, examples follow:
Example 1
Before

After

Example 2
Before

After

Example 3
Before

After

I think these examples show adequately what the feature is about. In my humble opinion, this is an improvement compared to the original version.
The PR also adds tests of the new implementation.