Fixed Resources window attempting to load sound files without snack.#163
Open
scidfork wants to merge 1 commit intobenini:githubfrom
Open
Fixed Resources window attempting to load sound files without snack.#163scidfork wants to merge 1 commit intobenini:githubfrom
scidfork wants to merge 1 commit intobenini:githubfrom
Conversation
Owner
|
Attention must be paid when copying existing code because it might not be particularly good. |
benini
force-pushed
the
github
branch
2 times, most recently
from
f96d38b to
404bda3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When selecting a sound folder in the Resources window, it would attempt to load the sounds even if it determined than snack was not available at startup. Now, it still allows the folder selection, but if snack is not available, it will simply pop up a message that informs you that sounds are disabled instead of attempting to load them.