Adding new London Overground line names#33
Conversation
|
@tgraynz is attempting to deploy a commit to the Benjamin Td Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
I've tested the Preview, and functionality for the new overground lines looks good to me. The route lines are still showing as the old colour on the map, which I've traced to a setting in the London 'config.ts' - if I set MAP_FROM_DATA to true then I see the correct line colours on the map. I don't know the history for why this setting exists, or how the lines are drawn if this isn't set, so I'm not entirely confident in adding that setting in - it may be preferable to change the line colours within the current method for drawing the lines. One thing that has occurred to me - I have preserved station id's for all other lines, and assigned new station id's for all stations on the new overground lines. This means that previous game scores will be slightly impacted, because for example if they had found Richmond, this previously would have counted as 2 (one for the District line and one for the Overground), whereas now only the District line station will be 'found' and the new Mildmay line station id will not be found, so they would have to enter Richmond again to go back to the previous state. Not sure how big a deal this is - there are options for working around this, but I can't think of a clean solution, particularly because there are stations that have multiple overground lines as well as tube lines, and so the overall station count has gone up. |
|
Ok that makes sense, yeah agreed may as well use the geojson file for London now. I will commit that change then. I did wonder about playing around with line styles - it would be good to have the parallel line style for the overground lines and the Elizabeth line, particularly because now the Windrush line looks very similar to the Central line. And that would require basically the same feature - offsetting orthogonally. But yes outside the scope of this PR. |
|
would you be interested in contributing this change? In this or another PR. |
|
Yeah for sure, I have a few other ideas for features I'd like to play around with as well |
|
I'm a little bit stuck here - the preview is still showing the old orange colour for all the overground lines, but my local testing shows the correct colours. Any ideas as to what could be going on? |
I'm getting this error on deploy; i'll take a look when I have time, sorry ! |

Added a custom preprocess script for London, manually changed source.json to create the new London Overground lines. Unable to fully test due to mapbox style issues.