Conversation
Updated all imports & uses of QtQuick.Controls to 2.0+; Used Kirigami for page layout and style management; Provided localization support via KF5::I18n (just to promote good practices and all); Added animations, to show that QuickFlux is compatible with them; Used ECMAScript 2016 features like const keyword and arrow functions.
06973f7 to
89d1805
Compare
|
hi @ratijas , Thanks for the patch. However, can it run on Mac/Windows? In Linux, what kind of packages required to build it? |
1 similar comment
|
hi @ratijas , Thanks for the patch. However, can it run on Mac/Windows? In Linux, what kind of packages required to build it? |
|
Is it wise to embed so much dependencies for a demo project? Do we need localized demo? |
|
Well, well, well. Look who's awake. I mean, given the political situation surrounding you, I'm glad you're alive at all. But excuse me princes — half a year time span? I doubt I could even remember what I was thinking back than. As far as I can tell, there was something in the patch which I wasn't happy about. Not sure anymore, though.
Should run anywhere. KDE Personally, I have some uneasy moments in life, my time is pretty limited, which is why I can't work on the patch right now, nor can I provide any estimate for the future. As it is, the patch probably is not good to merge. But you may take it and polish to your liking. New version, in my opinion, is clearly better in terms of UI/UX. |
|
Hi @ratijas, Sorry for my late reply about your PR and thank your for your concern. My life is not easy in the past year. I live in Hong Kong and now it is full of fear from the new National Law who could arrest people just because the government thinks you are saying ill of them, including foreigners everywhere. I don't know who, including me, will be the next. I got some free time this month so I am trying to resolve the Github issues. I understand it is very difficult to recall you have been done over a half year(me too!). So nevermind. Everyone here is not getting paid so you are free to choose when to reply/update it, or just give up. That is how the OSS world works :) Everyone has his uneasy moments in the life.. and I hope you will be fine soon. Improvements are always welcome but I think it is a bit too much for the todo example as it needs to add extra dependencies. I think the best way is to fork it as a new example (e.g todo-kde). Let me digest your changes first. Anyway, please feel free to suggest any improvement and contribute patches. I wish I could reply soon and it won't take another half year.... |
Updated all imports & uses of QtQuick.Controls to 2.0+;
Used Kirigami for page layout and style management;
Provided localization support via KF5::I18n (just to promote good practices and all);
Added animations, to show that QuickFlux is compatible with them;
Used ECMAScript 2016 features like const keyword and arrow functions.