This repository was archived by the owner on Jan 16, 2025. It is now read-only.
refactor: Refactor and optimize governance.ts for better maintainability#25
Open
tiendn wants to merge 1 commit intoberachain:mainL2from
Open
refactor: Refactor and optimize governance.ts for better maintainability#25tiendn wants to merge 1 commit intoberachain:mainL2from
tiendn wants to merge 1 commit intoberachain:mainL2from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhancements in governance.ts for Improved Code Quality
This PR introduces several improvements to the
governance.tsmodule to enhance readability, maintainability, and performance. Key changes include:Refactored opsResolution and treasuryResolution to use a shared helper function resolutionHelper, reducing code duplication and improving maintainability.
Modified timelockDelaySet to check delay constraints at the beginning of the function. This change ensures that the function fails fast before performing any operations if the delay exceeds the allowed maximum.
Updated asynchronous operations to consistently use async/await syntax, ensuring that all asynchronous code is easy to read and error handling is straightforward.
These changes aim to streamline the codebase and improve the overall quality of the governance module.
Files Modified:
misc/libs/governance.ts