Unwarper#12
Merged
Merged
Conversation
Contributor
|
I tested it on an EW2 skeleton: |
Contributor
|
For the toy data. These might be quite far away from the SAC bands at the boundaries and where the tissue is warped the most. 
So far away from the SACs it can actually fail, as we expected |
Contributor
|
Here is a HC, so quite far away from the SACs: |
Contributor
|
And a GLuMI cell: |
Collaborator
Author
|
For the purpose we intended (putting post-processed, unwarped skeletons back to the neuroglancer for visualization only), a bit of errors is tolerable (unless someone wants to do analysis on the unwarped skeletons, but why?). I will merge it now and make a new release (v0.2.5). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This RP added an approximate1 inverse of warped nodes (
unwarp_nodesandunwarp_skeleton).Footnotes
It's just an approximation because the algorithm from the original MATALB implementation uses per-node local polynomial least-squares fitting for the forward warping, which can not be exactly reversed. ↩