added outflow test MERGE BLOCKED BY KATHY#62
Open
eugenevinitsky wants to merge 2 commits intomasterfrom
Open
Conversation
Collaborator
eugenevinitsky
commented
Aug 16, 2018
eugenevinitsky
commented
- Renamed all tests so that they are actually run by appending them with test
- Added test for outflows
- Do not merge this until @kjang96 approves because I've removed methods that she is currently using
eugenevinitsky
requested review from
AboudyKreidieh and
cathywu
as code owners
| else: | ||
| return 0 | ||
|
|
||
| def additional_command(self): |
Collaborator
There was a problem hiding this comment.
did you mean to delete this? it's not mentioned in the overview or the commits
Collaborator
Author
There was a problem hiding this comment.
Yeah, that's why this is blocked. Can we just leave this PR open and I'll move it later?
| for veh_id in self.vehicles.get_ids(): | ||
| self._reroute_if_final_edge(veh_id) | ||
|
|
||
| def _reroute_if_final_edge(self, veh_id): |
| def test_collide_inflows(self): | ||
| """Tests collisions in the presence of inflows.""" | ||
| # create the environment and scenario classes for a ring road | ||
| # create the environment and scenario classes for a 1x1 grid |
| # test outflow rate | ||
| self.assertAlmostEqual(2*3600.0/15.0, vehicles.get_outflow_rate(100)) | ||
|
|
||
| # test get num arrived |
Collaborator
There was a problem hiding this comment.
are these coming later?
Collaborator
Author
There was a problem hiding this comment.
Yeah, just filled them out for future
AboudyKreidieh
approved these changes
Aug 16, 2018
Collaborator
AboudyKreidieh
left a comment
AboudyKreidieh
left a comment
There was a problem hiding this comment.
LGTM, pending comments
kjang96
pushed a commit
to kjang96/flow
that referenced
this pull request
Aug 17, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.