Fix stale docs: upgrade example, build_info note, CHAT compat version…#89
Merged
bernardladenthin merged 1 commit intomasterfrom Apr 18, 2026
Merged
Conversation
…, test prompt CLAUDE.md: - Remove brittle line number from GIT_TAG upgrade instructions; update example value to b8831 and upgrade example from b5016/b5022 to b8808/b8831; replace stale branch name with generic <your-branch> - Qualify "top 8 rows" claim: add note that CMakeLists.txt must also be reviewed for build-system-level breaks not visible in header diffs - Update common/common.h priority-table note: `build_info` was removed in b8831 (now `llama_build_info()` from `build-info.h`) CHAT_INTEGRATION_SUMMARY.md: - Clarify the implementation was done at b8611 (not "current codebase") - Update Upstream Compatibility section header to reflect that chat functionality has been verified compatible through b8831 CLAUDE_TEST_GENERATION_PROMPT.md: - Add status note at the top: all tasks have been executed; re-running as-is will conflict with existing files - Fix LlamaOutputTest spec: `testTextFromBytes` with `byte[]` constructor does not exist; correct to `testTextFromString` with `String` constructor https://claude.ai/code/session_01HJUr9LwrMNpT3FTwwzR6Gh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…, test prompt
CLAUDE.md:
build_infowas removed in b8831 (nowllama_build_info()frombuild-info.h)CHAT_INTEGRATION_SUMMARY.md:
CLAUDE_TEST_GENERATION_PROMPT.md:
testTextFromByteswithbyte[]constructor does not exist; correct totestTextFromStringwithStringconstructorhttps://claude.ai/code/session_01HJUr9LwrMNpT3FTwwzR6Gh