change Queryable as_object to return &str instead of &String#103
Merged
besok merged 1 commit intobesok:mainfrom Jul 2, 2025
Merged
change Queryable as_object to return &str instead of &String#103besok merged 1 commit intobesok:mainfrom
besok merged 1 commit intobesok:mainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Queryable trait and its Value implementation so that as_object returns &str keys rather than &String, allowing any AsRef<str>-backed type (like Box<str>) to implement the trait.
- Changed
Queryable::as_objectsignature from&Stringto&str - Updated the
Queryable for Valueimpl to callk.as_str()when building the vector - Broadens implementability to types beyond
String-keyed maps
Comments suppressed due to low confidence (2)
src/query/queryable.rs:73
- [nitpick] The trait method signature has changed to return
&strkeys—consider updating any associated doc comments to reflect this new behavior and note that implementers now accept anyAsRef<str>.
fn as_object(&self) -> Option<Vec<(&str, &Self)>>;
src/query/queryable.rs:73
- [nitpick] We should add unit tests for types with non-
Stringkeys (e.g.,Box<str>) to verify thatas_objectcorrectly returns&strreferences in practice.
fn as_object(&self) -> Option<Vec<(&str, &Self)>>;
besok
approved these changes
Jul 2, 2025
Owner
|
Good catch. Thanks for the pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the trait cannot be implemented for object keys that aren't actually a String, (we use Box) this way anything that implements AsRef can implement this trait