Skip to content

Critical problems with auth db connections #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dbnski wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Critical problems with auth db connections #12

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8b6317
Respect DatabaseExtraDSN
Apr 22, 2016
6d72539
RT::Handle implicitly sets UTF8, so we should also request data from …
Apr 22, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions lib/RT/Authen/ExternalAuth/DBI.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -615,10 +615,30 @@ sub _GetBoundDBIObj {
$dsn = "dbi:$dbi_driver:database=$db_database;host=$db_server;port=$db_port";
}

if (RT->Config->Get('DatabaseExtraDSN')) {
my %extra = RT->Config->Get('DatabaseExtraDSN');
$dsn .= ";$_=$extra{$_}"
for sort keys %extra;
}

my $db_type = RT->Config->Get('DatabaseType');
if ( $db_type eq 'Oracle' ) {
$ENV{'NLS_LANG'} = "AMERICAN_AMERICA.AL32UTF8";
$ENV{'NLS_NCHAR'} = "AL32UTF8";
}

# Now let's get connected
my $dbh = DBI->connect($dsn, $db_user, $db_pass,{RaiseError => 1, AutoCommit => 0 })
or die $DBI::errstr;

if ( $db_type eq 'mysql' ) {
$dbh->do("SET NAMES 'utf8'");
}

if ( $db_type eq 'Pg' ) {
$dbh->do("SET bytea_output = 'escape'");
}

# If we didn't die, return the DBI object handle
# and hope it's treated sensibly and correctly
# destroyed by the calling code
Expand Down