Add support to ignore and decorate Custom API implementations#4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dvx plugin adoptwas scaffolding[PluginStep]attributes for Custom API implementations, which aren't event plugins — their handlers run at stage 30 (Main Operation), so the generated attributes were invalid. This change makesadopt,sync, andregisterrecognize and skip Custom API registrations, and adds a[CustomApi]marker attribute to make the intent explicit in source.Changes
StepImporterskips Custom API steps — detected bystage == 30, a Custom API message, or a plugin type referenced bycustomapi.plugintypeid(newSdkMetadatalookups) — and marks the implementing class with[CustomApi]instead of[PluginStep].PluginDiscoveryskips[CustomApi]classes silently; the marker takes precedence over any[PluginStep]on the same class.[CustomApi]indvx.PluginAttributesmarks anIPluginclass as a Custom API implementation.dvx.PluginAttributes1.1.2→1.2.0;dvxCLI package iddvx→dvx.cli,1.6.0→1.6.1.Testing
Full suite green (230 tests); builds across
net462/net471/net9.0with no warnings. New tests cover discovery skip (including[CustomApi]+[PluginStep]), the three adopt detection signals, and idempotent marker writing. README andRegressionTests.mdupdated.Fixes #3