Fix crash to screen when a previously available provider has become unavailable#149
Open
steffenWi wants to merge 1 commit intobfabiszewski:masterfrom
Open
Fix crash to screen when a previously available provider has become unavailable#149steffenWi wants to merge 1 commit intobfabiszewski:masterfrom
steffenWi wants to merge 1 commit intobfabiszewski:masterfrom
Conversation
… when a provider was selected that is no longer available and an attempt is made to start logging. In my case I had previously selected Network and GPS, but after a major system upgrade the "Network" provider had, unbeknownst to me, become unavailable. When I then tried to start logging the application just crashed. - to provoke this issue, make sure that a provider is unavailable, then in ProviderPreferenceDialogFragment.java change the body of public boolean isEnabled(int position) to "return true;", start the application and select the provider that is unavailable, then try to switch on logging. Note: Yes, this is an extremely rare issue, though if it occurs a user is left with a crashing app after a major system update, which might leave some to believe the app has become incompatible or that something went wrong during the update.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The app currently crashes when a provider was selected that is no longer available and an attempt is made to start logging. In my case I had previously selected Network and GPS, but after a major system upgrade the "Network" provider had, unbeknownst to me, become unavailable. When I then tried to start logging the application just crashed.
public boolean isEnabled(int position)toreturn true;, start the application and select the provider that is unavailable, then try to switch on logging.Note: Yes, this is an extremely rare issue, though if it occurs a user is left with a crashing app after a major system update, which might leave some to believe the app has become incompatible or that something went wrong during the update.