Modify the error Regular expressions js in querystringvalues.js#65
Open
foru17 wants to merge 1 commit intobgrins:masterfrom
foru17:master
Open
Modify the error Regular expressions js in querystringvalues.js#65foru17 wants to merge 1 commit intobgrins:masterfrom foru17:master
foru17 wants to merge 1 commit intobgrins:masterfrom
foru17:master
Conversation
Owner
|
Hi, thanks for catching this. It looks like the js file itself is fine (https://github.com/bgrins/devtools-snippets/blob/master/snippets/querystringvalues/querystringvalues.js) so this is likely an error in the build step that grabs the file and renders it to HTML (somewhere around here): https://github.com/bgrins/devtools-snippets/blob/master/Rakefile#L21. A fix in the build would be ideal so that this doesn't get wiped out next time |
|
Hi, @bgrins! It's still wrong ni the output, though. Cheers, and thanks for this repo ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a error regular expressions js in the querystringvalues.js which result in a Uncaught SyntaxError.