WIP: Global-exports to require React and support node modules#127
Closed
Deraen wants to merge 1 commit intobhauman:masterfrom
Closed
WIP: Global-exports to require React and support node modules#127Deraen wants to merge 1 commit intobhauman:masterfrom
Deraen wants to merge 1 commit intobhauman:masterfrom
Conversation
6 tasks
Owner
|
Closing because this should be resolved. |
Author
|
How so? Devcards (and sablono) is still referring to |
Owner
|
Oh sorry, I was confused will reopen.
… On Oct 25, 2017, at 2:31 PM, Juho Teperi ***@***.***> wrote:
How so?
Devcards (and sablono) is still referring to js/React so it won't work when React from Node package.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Owner
|
this is fixed with 4881652 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is similar to reagent-project/reagent#306
https://github.com/reagent-project/reagent/blob/master/CHANGELOG.md#080-alpha1-2017-07-31
I'm opening PR's on other related projects also:
It is possible further changes to ClojureScript will make this change (partially) unnecessary: https://dev.clojure.org/jira/browse/CLJS-2331
Build causes lots of warnings:
It is probably these are caused by problems in Om.
Some views work on browser, but there are some errors on console and at least om.next card is empty: