Imports aus ILIAS 4 und ILIAS EA ermöglichen#8
Open
lieblb wants to merge 2033 commits intobheyser:trunkfrom
Open
Imports aus ILIAS 4 und ILIAS EA ermöglichen#8lieblb wants to merge 2033 commits intobheyser:trunkfrom
lieblb wants to merge 2033 commits intobheyser:trunkfrom
Conversation
Fix restrict method does not longer exists. Use applyTo instead of re…
Co-Authored-By: legionth <niels.theen@googlemail.com>
…rainViolationException
[Fix 25368] Fix copy ilobjects
…it-tests Adapt behavior of NewMethodTransformation. NewMethodTransformations n…
…/result rendering
Initialize $objectives as array().
…m test player does come around this
This reverts commit 0d7904e.
…_zipfolders [Fix 22296] Fix calendar dates for booking pool reservations
…readme_caught Refinery: Fixed catched/caught in README
* move icon and glyph to symbol, starting out * apply symbol-changes to src and tests * apply symbol to Services * docs * use slate with symbol * fix some tests * update less * update tests * fix test * =fix another test * adjust an example path
…he PhpStorm tools and an additional search for usages when refactoring code!)
This would allow to import older tests from ILIAS 4 and ILIAS EA.
bheyser
pushed a commit
that referenced
this pull request
Jul 17, 2020
…n object that implements Countable Fixing error by using ldap-user-sync. replace debug message after checking for an array ERROR-LOG: ilCronManager::runJob:95 count(): Parameter must be an array or an object that implements Countable ilCronManager::runJob:95 #0 ILIAS_PATH/Services/Init/classes/class.ilErrorHandling.php(461): Whoops\Run->handleError(2, 'count(): Parame...', 'ILIAS_PATH...', 387) #1 ILIAS_PATH/Services/LDAP/classes/class.ilLDAPQuery.php(387): ilErrorHandling->handlePreWhoops(2, 'count(): Parame...', 'ILIAS_PATH...', 387, Array) #2 ILIAS_PATH/Services/LDAP/classes/class.ilLDAPQuery.php(131): ilLDAPQuery->fetchGroupMembers() #3 ILIAS_PATH/Services/LDAP/classes/class.ilLDAPCronSynchronization.php(87): ilLDAPQuery->fetchUsers() #4 ILIAS_PATH/Services/Cron/classes/class.ilCronManager.php(178): ilLDAPCronSynchronization->run() #5 ILIAS_PATH/Services/Cron/classes/class.ilCronManager.php(95): ilCronManager::runJob(Object(ilLDAPCronSynchronization), Array, true) #6 ILIAS_PATH/Services/Cron/classes/class.ilCronManagerGUI.php(282): ilCronManager::runJobManual('ldap_sync') #7 ILIAS_PATH/Services/Cron/classes/class.ilCronManagerGUI.php(64): ilCronManagerGUI->confirmedRun() #8 ILIAS_PATH/Services/UICore/classes/class.ilCtrl.php(210): ilCronManagerGUI->executeCommand() #9 ILIAS_PATH/Modules/SystemFolder/classes/class.ilObjSystemFolderGUI.php(152): ilCtrl->forwardCommand(Object(ilCronManagerGUI)) ILIAS-eLearning#10 ILIAS_PATH/Services/UICore/classes/class.ilCtrl.php(210): ilObjSystemFolderGUI->executeCommand() ILIAS-eLearning#11 ILIAS_PATH/Services/Administration/classes/class.ilAdministrationGUI.php(250): ilCtrl->forwardCommand(Object(ilObjSystemFolderGUI)) ILIAS-eLearning#12 ILIAS_PATH/Services/UICore/classes/class.ilCtrl.php(210): ilAdministrationGUI->executeCommand() ILIAS-eLearning#13 ILIAS_PATH/Services/UICore/classes/class.ilCtrl.php(175): ilCtrl->forwardCommand(Object(ilAdministrationGUI)) ILIAS-eLearning#14 ILIAS_PATH/ilias.php(20): ilCtrl->callBaseClass() ILIAS-eLearning#15 {main}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Björn,
diese Änderung (bafd698) ermöglich den Import alter Tests aus ILIAS 4 und ILIAS EA. Das ist z.B. für uns und glaube ich auch Marburg ein Thema, weil wir immer noch die Altinstallation haben, aus denen wir in den kommenden Monaten Daten und Tests migrieren müssen.
Ich weiß natürlich, dass beides längst nicht mehr offiziell supported ist. Gleichzeitig ist dies die einzige Stelle, die einen funktionsfähigen Basisimport verhindert (ob dann alles stimmt, ist natürlich das Problem des Importierenden bei so einer Versionsdifferenz - aber soweit ich das hier momentan sehe, funktioniert das in der Praxis immer noch ziemlich gut).
Der PR setzt einfach ein FIXED questionset im QTIParser als default, weil diese Einstellung offenbar in den alten XML-Dateien nicht vorkommt und daher nicht gesetzt wird. Dadurch schlägt dann in
ilObjTestGUI::uploadTstObjectfolgender Code zu, der den Import in diesen Fällen zunichte macht (getQuestionSetType()liefert bei ILIAS-4-Tests nämlich das defaultnull):