Conversation
|
You can probably merge both of mine. There's more work to be done, but the existing changes are an improvement, and the outstanding ones aren't critical in either case. |
|
Sounds good. I merged master into both. If tests pass, I'll run fitlins against both to make sure that we're not horribly breaking anything. |
Codecov Report
@@ Coverage Diff @@
## master #375 +/- ##
=======================================
Coverage 73.79% 73.79%
=======================================
Files 23 23
Lines 2492 2492
Branches 621 621
=======================================
Hits 1839 1839
Misses 471 471
Partials 182 182
Continue to review full report at Codecov.
|
|
Re #365: i have updated the PR to rely exclusively on self.index length instead of computations, and got rid of the confusing warnings. Re #367: I believe this issue/PR highlighted an underlying problem (#367 (comment)) that once solved would make the warning superfluous. So I would say this can be closed, but should be referenced in an issue as a reminder. Re #277: I have to admit, I've lost an overview of where this and the related discussions went. Do I understand @tyarkoni 's comment correctly that I should submit a separate PR which includes dot-directories in the exclude list? Anyway this is okay to close. |
We've had a burst of fixes lately, and I think it would be good to go ahead and have another release before #369.
Pending merge or postponement decision on:
I'm going to start a 0.7.1 milestone. Please tag your PRs with that milestone iff you want to block release on their merge. If you are okay with postponing to 0.7.2 or 0.8.0, just go ahead and check the box above.