Skip to content

REL: 0.7.1#375

Merged
effigies merged 6 commits into
masterfrom
rel/0.7.1
Feb 1, 2019
Merged

REL: 0.7.1#375
effigies merged 6 commits into
masterfrom
rel/0.7.1

Conversation

@effigies

@effigies effigies commented Feb 1, 2019

Copy link
Copy Markdown
Collaborator

We've had a burst of fixes lately, and I think it would be good to go ahead and have another release before #369.

Pending merge or postponement decision on:

I'm going to start a 0.7.1 milestone. Please tag your PRs with that milestone iff you want to block release on their merge. If you are okay with postponing to 0.7.2 or 0.8.0, just go ahead and check the box above.

@effigies effigies added this to the 0.7.1 milestone Feb 1, 2019
@tyarkoni

tyarkoni commented Feb 1, 2019

Copy link
Copy Markdown
Collaborator

You can probably merge both of mine. There's more work to be done, but the existing changes are an improvement, and the outstanding ones aren't critical in either case.

@effigies

effigies commented Feb 1, 2019

Copy link
Copy Markdown
Collaborator Author

Sounds good. I merged master into both. If tests pass, I'll run fitlins against both to make sure that we're not horribly breaking anything.

@codecov

codecov Bot commented Feb 1, 2019

Copy link
Copy Markdown

Codecov Report

Merging #375 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #375   +/-   ##
=======================================
  Coverage   73.79%   73.79%           
=======================================
  Files          23       23           
  Lines        2492     2492           
  Branches      621      621           
=======================================
  Hits         1839     1839           
  Misses        471      471           
  Partials      182      182
Flag Coverage Δ
#unittests 73.79% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6984cdd...7460e12. Read the comment docs.

@adswa

adswa commented Feb 1, 2019

Copy link
Copy Markdown
Contributor

Re #365: i have updated the PR to rely exclusively on self.index length instead of computations, and got rid of the confusing warnings.

Re #367: I believe this issue/PR highlighted an underlying problem (#367 (comment)) that once solved would make the warning superfluous. So I would say this can be closed, but should be referenced in an issue as a reminder.

Re #277: I have to admit, I've lost an overview of where this and the related discussions went. Do I understand @tyarkoni 's comment correctly that I should submit a separate PR which includes dot-directories in the exclude list? Anyway this is okay to close.

@tyarkoni

tyarkoni commented Feb 1, 2019

Copy link
Copy Markdown
Collaborator

Agreed that #367 can be closed (and also that we should open a new issue for the proposed fix). Re: #277, we still need a fix, but best to defer it until after #369 is merged, because the file indexing process is radically different, and there's no reason to do double the work.

Comment thread .zenodo.json Outdated
@effigies effigies merged commit f13b800 into master Feb 1, 2019
@effigies effigies deleted the rel/0.7.1 branch February 1, 2019 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants