Remove reports module in favor of pybids-reports namespace package#814
Draft
tsalo wants to merge 6 commits into
Draft
Remove reports module in favor of pybids-reports namespace package#814tsalo wants to merge 6 commits into
tsalo wants to merge 6 commits into
Conversation
Codecov ReportBase: 86.31% // Head: 85.59% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #814 +/- ##
==========================================
- Coverage 86.31% 85.59% -0.72%
==========================================
Files 35 30 -5
Lines 4033 3665 -368
Branches 976 903 -73
==========================================
- Hits 3481 3137 -344
+ Misses 356 348 -8
+ Partials 196 180 -16
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This was referenced Feb 16, 2022
Contributor
|
OK so the pybids-reports has been released so we can now think of how to take it out of pybids proper. @effigies do you want to go though a deprecation cycle for a couple of releases before we remove it with a warning to let people know about the new package? |
Collaborator
|
Ah, we should probably get back to this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #801. This PR removes everything related to the
reportsmodule, since we will move to using a namespace package calledpybids-reports. This will remain a draft until I've addressed the to-do list below.To do:
pybids-reports(tracking with Release and push to PyPi pybids-reports#17)pybids