feat: Support userdata placeholders #28
Merged
Merged
Conversation
GuiLeme
self-requested a review
June 10, 2025 16:16
GuiLeme
requested changes
Jun 11, 2025
GuiLeme
left a comment
GuiLeme
left a comment
Contributor
There was a problem hiding this comment.
One minor issue: the userdata information hasn't been replaced correctly, the curly braces remained there, see:
GuiLeme
self-requested a review
June 11, 2025 16:43
GuiLeme
requested changes
Jun 16, 2025
GuiLeme
left a comment
GuiLeme
left a comment
Contributor
There was a problem hiding this comment.
It looks good, just those 2 adjustments, and we're fine!
GuiLeme
self-requested a review
June 16, 2025 16:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR improves the Generic Link Share plugin by enhancing the logic to accept userdata params and use the values as placeholders.
Key changes include:
Closes Issue(s)
Closes #27
Motivation
These changes aim to make the link sharing experience more robust, ensuring that URLs are handled securely and that the UI responds correctly to data updates.
Please review and let me know if further adjustments are required!