Skip to content

fix: Modal priority set to low #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antobinary merged 3 commits into from
Oct 15, 2025
Merged

fix: Modal priority set to low #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f4c234e
[modal-fix] removed references to plugin-decrease-volume-on-speak, up…
GuiLeme Sep 8, 2025
a1e740b
[modal-fix] duplication removal
GuiLeme Sep 9, 2025
bd4c08a
[modal-fix] add parent selector
GuiLeme Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"@types/react": "^18.2.13",
"@types/react-dom": "^18.2.7",
"babel-plugin-syntax-dynamic-import": "^6.18.0",
"bigbluebutton-html-plugin-sdk": "0.0.84",
"bigbluebutton-html-plugin-sdk": "0.0.93",
"path": "^0.12.7",
"react": "^18.2.0",
"react-dom": "^18.2.0",
Expand Down
4 changes: 2 additions & 2 deletions public/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@
<meta name="viewport" content="width=device-width, initial-scale=1" />
<meta
name="description"
content="Plugin decrease volume on speak"
content="Plugin Generic Link Share"
/>
<title>Decrease volume on speak</title>
<title>Plugin Generic Link Share</title>
</head>
<body>
<div id="root"></div>
Expand Down
4 changes: 2 additions & 2 deletions src/components/generic-link-share/component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import GenericComponentLinkShare from '../generic-component/component';
import {
CurrentUserData,
DataToGenericLink,
DecreaseVolumeOnSpeakProps,
GenericLinkShareProps,
UserMetadataGraphqlResponse,
} from './types';
import { ModalToShareLink } from '../modal-to-share-link/component';
Expand All @@ -31,7 +31,7 @@ import { mergePlaceholdersList, replaceUrlPlaceholders } from './utils';
import { USER_METADATA } from './subscription';

function GenericLinkShare(
{ pluginUuid: uuid }: DecreaseVolumeOnSpeakProps,
{ pluginUuid: uuid }: GenericLinkShareProps,
): React.ReactElement {
BbbPluginSdk.initialize(uuid);
const pluginApi: PluginApi = BbbPluginSdk.getPluginApi(uuid);
Expand Down
4 changes: 2 additions & 2 deletions src/components/generic-link-share/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
interface DecreaseVolumeOnSpeakProps {
interface GenericLinkShareProps {
pluginName: string,
pluginUuid: string,
}
Expand Down Expand Up @@ -39,4 +39,4 @@ export interface PlaceholderEntry {
value: string | boolean;
}

export { DecreaseVolumeOnSpeakProps, ExternalVideoMeetingSubscription, DataToGenericLink };
export { GenericLinkShareProps, ExternalVideoMeetingSubscription, DataToGenericLink };
5 changes: 3 additions & 2 deletions src/components/modal-to-share-link/component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,10 @@ export function ModalToShareLink(props: ModalToShareLinkProps) {
} else setIsViewerUrlAlreadyFormated(false);
}, [previousModalState]);

return (
return showModal && (
<Styled.PluginModal
className="modal-high"
portalClassName="modal-low"
parentSelector={() => document.querySelector('#modals-container')}
overlayClassName="modalOverlay"
Comment thread
GuiLeme marked this conversation as resolved.
ariaHideApp={false}
isOpen={showModal}
Expand Down
1 change: 0 additions & 1 deletion tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
"target": "es5",
"jsx": "react",
"allowJs": true,
"skipLibCheck": true,
"moduleResolution": "node",
"esModuleInterop": true
},
Expand Down