Migrate from thin to puma for the web server#25
Merged
Merged
Conversation
splittingred
approved these changes
Dec 9, 2024
Contributor
splittingred
left a comment
There was a problem hiding this comment.
Looks good. Any impact to memory usage relative to thin?
Contributor
|
Also @j05h - does this cause any issue when being used alongside another Puma server in a separate thread? |
Contributor
Author
I haven't seen any issues to date. We've upgraded an app with Rails 7.1 and are doing some testing on that now. |
Contributor
Author
They seem relatively equivalent. On thin: On Puma: This is local on my Mac, so likely its not an Apples-to-Penguins comparison to Linux. Will try to get some data from our test app. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What? Why?
Thin still does not support Rack 3.0, which is needed because Sinatra needs an update due to GHSA-hxx2-7vcw-mqr3.
Given the Thin update is almost a year old, this PR migrates from Thin to Puma as the server for metrics.
How was it tested?
Integrated with a Rails app:
Resident set size (RSS) graph for a simple Rails app. 14:45-16:00 is the period we had this deployed (along with an upgrade from Rails 7.0 to 7.1). The memory footprint does grow, but only by about 3mb.