Support multiple controllers paths#213
Closed
salmanasiddiqui wants to merge 0 commit intobigcommerce:mainfrom
Closed
Support multiple controllers paths#213salmanasiddiqui wants to merge 0 commit intobigcommerce:mainfrom
salmanasiddiqui wants to merge 0 commit intobigcommerce:mainfrom
Conversation
splittingred
requested changes
Nov 19, 2024
lib/gruf/autoloaders.rb
Outdated
| # | ||
| def load!(controllers_path:) | ||
| controllers(controllers_path: controllers_path) | ||
| def load!(controllers_paths:) |
Member
There was a problem hiding this comment.
Hi @salmanasiddiqui - while this is a good change to support multiple paths, this unfortunately makes a backwards incompatible change here I'd like to avoid.
Can we add this as a new keyword argument, and deprecate the old one (to be removed in gruf 3.0). We should support both syntaxes in 2.x.
Author
There was a problem hiding this comment.
Hey @splittingred, I have created a new PR with the suggestion you made #228.
I had to create a new branch in my fork to allow the main branch be synced. Thats why this PR been closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What? Why?
I ran into a problem in a Rails app which was made up of multiple Rails engines. The problem was that two engines were using Gruf and when they were used in same Rails app, the Gruf config for
controllers_pathwas getting overridden.So to fix that problem, I patched Gruf to support multiple paths for controllers by adding a new config field
controllers_paths. This field defaults to[controllers_path]. Gruf uses thiscontrollers_pathsinstead ofcontrollers_patheverywhere, butcontrollers_pathis kept in config for backward compatibility.Note: I think the config should support something like
add_controllers_paths, instead of directly settingcontrollers_paths. That will allow multiple modules to add their controllers path without messing with the existing paths. Let me know if you like this idea, I will update the PRHow was it tested?
All the specs are passing