Fix Android signing preflight env names + add direct-APK profile#3
Merged
Merged
Conversation
…ning doc release-preflight.js checked PEARBROWSER_ANDROID_KEYSTORE/STORE_PASSWORD/KEY_ALIAS, but android/app/build.gradle actually signs from PEARBROWSER_RELEASE_STORE_FILE/ STORE_PASSWORD/KEY_ALIAS/KEY_PASSWORD — so a "configured" preflight could still produce a build signed with the debug key. Reconcile preflight to the names that sign the build. - scripts/release-preflight.js: ANDROID_SIGNING_ENV + keystore-path var + remedy text now use the four PEARBROWSER_RELEASE_* names build.gradle reads. - test/release-preflight.test.js: fixture uses the reconciled names. - eas.json: add a production-apk build profile (direct-download APK) and a Play internal submit track. - docs/RELEASE_SIGNING.md: exact keytool + build/submit commands for Android (direct .apk and Play .aab) and iOS (App Store / TestFlight). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug
scripts/release-preflight.jsvalidatedPEARBROWSER_ANDROID_KEYSTORE/PEARBROWSER_ANDROID_STORE_PASSWORD/PEARBROWSER_ANDROID_KEY_ALIAS, butandroid/app/build.gradleactually signs the release build fromPEARBROWSER_RELEASE_STORE_FILE/_STORE_PASSWORD/_KEY_ALIAS/_KEY_PASSWORD. So you could set the preflight-recommended vars, get a green"Android production signing configured", and still ship a build signed with the
debug key. Reconciled preflight to the names that actually sign.
Changes
scripts/release-preflight.js:ANDROID_SIGNING_ENV+ keystore-path var +remedy text now use the four
PEARBROWSER_RELEASE_*namesbuild.gradlereads.test/release-preflight.test.js: fixture uses the reconciled names (3/3 green).eas.json: add aproduction-apkbuild profile (direct-download APK) and aPlay
internalsubmit track.docs/RELEASE_SIGNING.md: exactkeytool+ build/submit commands for Android(direct
.apkand Play.aab) and iOS (App Store / TestFlight).Scoped to these four files only.
🤖 Generated with Claude Code