Fix MakeCommerce DTS build#5
Merged
Merged
Conversation
Co-Authored-By: Paperclip <noreply@paperclip.ing>
nahremenkova1
approved these changes
May 11, 2026
Collaborator
nahremenkova1
left a comment
nahremenkova1
left a comment
There was a problem hiding this comment.
Reviewed the DTS build fix. Verified npm ci, npm run build, npm run typecheck, and npm test locally; DTS now emits dist/index.d.ts and dist/nest/index.d.ts successfully.
biggora
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tsup.config.tsto use named entries for the root and NestJS entrypoints.@biggora/klixand@biggora/payseraby settingoutDirand externalizing NestJS/RxJS peer packages.Root cause
The array entry form caused the DTS build to treat
dist/nest/index.d.tsas an input/output collision duringnpm run build, failing withTS5055after JavaScript output succeeded.Validation
npm run buildinmakecommerce: passed after the config change.npm testinmakecommerce: 4 files, 12 tests passed.npm run typecheckinmakecommerce: passed.klixandpaysera; both passed.