Skip to content

fix: scale lr instead of loss #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chungongyu merged 1 commit into from
Feb 4, 2026
Merged

fix: scale lr instead of loss #393

chungongyu merged 1 commit into from
Feb 4, 2026
+22 −12

Conversation

@chungongyu
Copy link
Member

@chungongyu chungongyu commented Feb 4, 2026

No description provided.

@chungongyu chungongyu added bug Something isn't working enhancement New feature or request labels Feb 4, 2026
@chungongyu chungongyu merged commit 4d8e156 into main Feb 4, 2026
2 checks passed
@chungongyu
Copy link
Member Author

chungongyu commented Feb 4, 2026

For Adam, sometimes scaling by $\sqrt{M}$ is more effective than scaling by $M$.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@chungongyu