[Issue #32] Update to use standard submitters#35
Closed
figuerom16 wants to merge 3 commits intobigskysoftware:masterfrom
figuerom16:upRead
Closed
[Issue #32] Update to use standard submitters#35figuerom16 wants to merge 3 commits intobigskysoftware:masterfrom figuerom16:upRead
figuerom16 wants to merge 3 commits intobigskysoftware:masterfrom
figuerom16:upRead
Conversation
|
I applied this change lokally and it does not work for the reason I gave in Issue #32 Did you maybe also have an fx-action on the form during your tests or explicitly set fx-trigger to click on the button? |
Contributor
Author
|
@NReib You're right it doesn't work without fx form attributes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #32
Competing PRs: #33 #34
Difference from PRS: Correct issue early by setting "submit" event to elt.__fixi.evt and fx-trigger
Outcome: Native default behavior for form submissions (eg form button click includes name and value on send).
Native Form Submit Buttons https://developer.mozilla.org/en-US/docs/Glossary/Submit_button:
<button>(its default type is "submit")<input type="submit"><input type="image">Add CSS selectors for forms to pick submit event: