SSE Extension: Default sse-swap="message" to keep setup simple#178
Open
scriptogre wants to merge 2 commits intobigskysoftware:mainfrom
Open
SSE Extension: Default sse-swap="message" to keep setup simple#178scriptogre wants to merge 2 commits intobigskysoftware:mainfrom
sse-swap="message" to keep setup simple#178scriptogre wants to merge 2 commits intobigskysoftware:mainfrom
Conversation
✅ Deploy Preview for htmx-extensions canceled.
|
|
Would this work for multiple nested <div sse-connect="/events">
<div sse-swap="foo"></div>
<div sse-swap="bar"></div>
</div>I'm wondering if this pull request would implicitly add |
Author
|
That's a very good concern! Thanks for catching that for me. Let me test it out and see. |
The sse-swap attribute now defaults to "message" only when an element has sse-connect but no sse-swap AND no nested sse-swap elements. This preserves the common pattern of using parent elements as containers for multiple sse-swap children without conflicting message event listeners.
Author
|
The latest commit should handle it gracefully. I also added an explicit test for the scenario you described. |
message event for sse-swapSSE Extension: Default sse-swap="message"` to keep setup simple
SSE Extension: Default sse-swap="message"` to keep setup simplesse-swap="message" to keep setup simple
Author
|
This PR would also make #180 more neat. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I wish this minimal setup just worked™:
Expectation:
Payload from
data:swaps directly into<div sse-connect=...>(using default swap strategyinnerHTML).Reality:
Unnamed events are ignored, unless you add
sse-swap="message"tosse-connectelement.Why?
I understand browsers treat unnamed SSE events as
messageby default, but with this change we could:hx-get/hx-post(wherehx-target="this"is implicit)Implementation
Add
sse-swap="message"by default on thesse-connectelement (unless there's any nestedsse-swapattributes).Edge Cases
Nested swaps
The pattern of using nested
sse-swapattributes should continue to work (default is not applied in this scenario).Triggering Server Callbacks
The pattern of triggering server callbacks should continue to work normally because the default
messagelistener only catches unnamed events.Htmx version: 2.0.6
Used extension(s) version(s): 2.2.2
Checklist
npm run test) and verified that it succeeded