Add target selector to htmx:oobErrorNoTarget event detail and logging#3643
Closed
RensDimmendaal wants to merge 27 commits intobigskysoftware:devfrom
Closed
Add target selector to htmx:oobErrorNoTarget event detail and logging#3643RensDimmendaal wants to merge 27 commits intobigskysoftware:devfrom
RensDimmendaal wants to merge 27 commits intobigskysoftware:devfrom
Conversation
Add Nomini to alternatives.md
…late fragments (bigskysoftware#3576) Add Askama to the list of template engines that support fragments
…Olympics (bigskysoftware#3627) * Add essay: Building Critical Infrastructure with htmx for Paris 2024 Olympics * Refine essay: clarify wording, add note on Tour de France 2025 reuse * add comma and "the" --------- Co-authored-by: Rodolphe Trujillo <rodolphe.trujillo@arolo-solutions.com>
Contributor
Author
|
much too large diff, rebase error. sorry! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When an oob swap fails to find its target element, the
htmx:oobErrorNoTargeterror is logged but doesn't indicate which selector failed. This makes debugging difficult.This PR:
targetto thehtmx:oobErrorNoTargetevent detail (matchinghtmx:targetErrorwhich already has this)targetpropertyBefore:
After:
Testing
Checklist
masterfor website changes,devforsource changes)
approved via an issue (I'm not sure if you'd consider this a bugfix/new feature...happy to re-open this as an Issue!)
npm run test) and verified that it succeeded