-
Notifications
You must be signed in to change notification settings - Fork 28
Add AriaMixins #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
geoffrey-eisenbarth
wants to merge
16
commits into
bigskysoftware:framework-exploration
Choose a base branch
from
geoffrey-eisenbarth:framework-exploration
base: framework-exploration
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add AriaMixins #149
geoffrey-eisenbarth
wants to merge
16
commits into
bigskysoftware:framework-exploration
from
geoffrey-eisenbarth:framework-exploration
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dz4k
reviewed
Jan 19, 2026
src/js/aria.js
Outdated
| } | ||
| ) | ||
|
|
||
| export const AriaInvalid = AriaState("invaid") |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to make the changes a little easier to understand, I kept some of the file names (like
selectable.js,checkable.js,multiselectable.js) that I think would eventually just go inaria.js.I'm still warming up to
ariaState(),ariaProperty(), etc. Sometimes it feels like it could be better to just be explicit and set e.g.el.ariaDisabled = "true"; perhaps I'll come around, let's give it more time.Some decision points:
AriaCheckedandAriaSelectedinheritAriaDisabled?validate()errors don't help the author find exactly which elements are throwing (it prints[HTMLElement]as a string instead of linking to the DOM)[aria-controls]attributes, or can we handle it ininternals()/ariaRelatives()by assuming first tab goes with first tabpanel, etc. Doing so would make for much simpler markup.OptGroup, it's important that no one is addingtabindexbecause it would interfere withFocusGroupMixin. Is there a way to do this without listening forattribute:tabindex?Either a validation, or..?There's still some small bugs:
aria-selected="true", then no panels show. We should opt for displaying the first oneblurevent isn't capable of unselecting the previously selected tab. This change came from removing theattribute:tabindexlistener (which felt a bit much, imagine a listbox with many options, and every time the tab roves it fires on all options).[disabled]in a focusgroup (and possibly wrap)<input type=text>inside<toolbar>.