Skip to content

ShipmentType in Shipment model is missing #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
knaepel wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ShipmentType in Shipment model is missing #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/Model/Shipment.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,13 @@ class Shipment
*/
public $shippingProductId = 0;

/**
* 0 if Shipment, 1 if Retoure
* @var int
* @DataField(name="ShipmentType", type="int")
*/
public $shipmentType = 0;
Copy link
Copy Markdown
Contributor

@devtronic devtronic Mar 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using magic numbers it's better to use constants. Please create a src/Type/ShipmentType.php and add the constants SHIPMENT=0 and RETOURE=1. Use ShipmentType::SHIPMENT in this class.
(Similar to the definition of ProductCondition and its usage:

billbee-php-sdk/src/Model/Product.php

Line 416 in 07409bc

public $condition = ProductCondition::BRAND_NEW;
)


/**
* Creates a shipment based on models
*
Expand Down