fix: SFTP download backpressure and binary transfer (#492)#493
Merged
billchurch merged 8 commits intomainfrom Mar 13, 2026
Merged
fix: SFTP download backpressure and binary transfer (#492)#493billchurch merged 8 commits intomainfrom
billchurch merged 8 commits intomainfrom
Conversation
Fixes large file downloads (300MB+) causing 'ping timeout' disconnects by throttling chunk emission when the WebSocket send buffer is full. Resolves #492
- Add isEmitting flag to emitBufferedChunks to prevent concurrent coroutines from racing on nextChunkToEmit/chunkBuffer with DOWNLOAD_CONCURRENCY=32 - Store BackpressureController in a Map keyed by transferId so handleDownloadCancel can destroy it and unblock any pending drain wait - Use config socketHighWaterMark value instead of hardcoded constant for backpressure high water mark
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
app/socket/backpressure.tsfor reuseBufferover Socket.IO (native binary support), eliminating 33% wire overhead and encode/decode CPUemitBufferedChunkscoroutines from racing on shared state (concurrency=32)BackpressureControlleris destroyed when downloads are cancelled mid-transferFixes #492
Test plan