fix(sfu): build against mediasoup 3.20 type API#26
Merged
Conversation
The Jun-2026 dependency bump moved the SFU to mediasoup ^3.20.2, whose type surface changed and broke `tsc` (caught by the new smoke-test workflow): - `SctpCapabilities` is no longer exported — drop the import and the param type. - `WebRtcTransportOptions` dropped `numSctpStreams`; a transport now just sets `enableSctp`. createTransport takes a plain `enableSctp` boolean (derived from whether the client advertised SCTP capabilities). - `DtlsParameters.role` is now optional (string | undefined); make the WHIP SDP helper's role param optional to match (it already falls back to 'actpass'). Verified locally with `npm run build` (tsc exit 0). https://claude.ai/code/session_01AMiTSxG8rB8FU8QgJ3Fnhs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The new smoke-test workflow did its job on the first run — it caught that the SFU does not compile against the mediasoup version bumped in the Jun-2026 dependency update.
npm install(native build) succeeded on the runner; thetscstep failed with 4 type errors.mediasoup
^3.20.2breaking changes, now fixed:SctpCapabilitiesremoved from the public types → dropped the import and the param type.numSctpStreamsremoved fromWebRtcTransportOptions→createTransportnow takes a plainenableSctpboolean (derived from whether the client advertised SCTP capabilities); the transport just setsenableSctp.DtlsParameters.roleis now optional (string | undefined) → made the WHIP SDP helper'sroleparam optional to match (it already falls back toactpass).Verified locally with
npm run build→ tsc exit 0.This unblocks the smoke-test workflow, which will now proceed past the SFU build to actually boot Redis + coturn + SFU and run the health/auth/port assertions.
https://claude.ai/code/session_01AMiTSxG8rB8FU8QgJ3Fnhs
Generated by Claude Code