Skip to content

Use vi.SpyOn instead of overriding global functions #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DysphoricUnicorn merged 1 commit into from
Apr 29, 2026
Merged

Use vi.SpyOn instead of overriding global functions #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions src/__tests__/filterHelper.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,7 @@ describe.each([
});

test('Test non implemented filter is skipped with warning', () => {
const warn = vi.fn();
global.console.warn = warn;
const warn = vi.spyOn(console, 'warn');
expect(applyFilters([
{
'field': 'banana',
Expand Down Expand Up @@ -559,8 +558,7 @@ describe.each([
});

test('test date filter DateRange skipped when value not implemented', () => {
const error = vi.fn();
global.console.error = error;
const error = vi.spyOn(console, 'error');
expect(
applyFilters([
{
Expand Down Expand Up @@ -640,8 +638,7 @@ describe.each([
});

test('test childAttr filter is skipped when no data is set', () => {
const warn = vi.fn();
global.console.warn = warn;
const warn = vi.spyOn(console, 'warn');
expect(
applyFilters([
{
Expand Down Expand Up @@ -690,8 +687,7 @@ describe.each([
});

test('test childArrayAttr filter is skipped when no data set', () => {
const warn = vi.fn();
global.console.warn = warn;
const warn = vi.spyOn(console, 'warn');
expect(
applyFilters([
{
Expand Down
1 change: 1 addition & 0 deletions vitest.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,6 @@ export default defineConfig({
reportsDirectory: './reports',
},
outputFile: 'reports/unit.test.xml',
restoreMocks: true,
},
});