Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧪 Test Contribution
📝 Description
Fixed E2E Test Infrastructure and Added Web Auth Flow Tests
This PR fixes multiple issues with the E2E test setup and adds comprehensive web authentication tests.
Issues Fixed
expect().status()awaitbeforerequest.post()awaitand fixed assertion syntaxtest.describe.configure({ mode: 'serial' })namefield in sign-upnameto user object and requestlocalhosthostmachinealias via--add-hostAPI_URLenv var.env.testChanges Made
tests/api/auth.spec.tsnamefield, fixedawaittests/web/web-auth-flow.spec.tsplaywright.config.tsapps/api/.env.testAPI_URLenv variablescripts/test-bootstrap.js.github/workflows/ci.yml🎯 Test Type
npm run test:e2enpm run test:unit(in apps/api)npm run test:unit(in apps/web)✅ Checklist
Local Setup for Fedora
docker run --rm --network host --init -it mcr.microsoft.com/playwright:v1.58.0-jammy \ /bin/sh -c "npx -y playwright@1.58.0 run-server --port 3001 --host 0.0.0.0"📸 Screenshots / Trace
Fixes: #78