[FIX] Frequent itemsets: fixed "autocommit" button states#66
Merged
Conversation
Member
Author
|
@janezd, I see that you fixed a similar problem in Association Rules years ago by just removing the "auto" option. If you think this fix is OK, I'll also update Associate Rules accordingly (they mostly follow the same structure). |
Contributor
|
@markotoplak , thanks. I probably changed Association Rules to avoid having two auto-commits in the same widget. But now I think this wasn't a good idea because the user has no indication that rules are outdated. As you wrote: many other problems remain to be solved in this (neglected) add-on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #64 and a handful of assorted bugs found while testing the widget.
Many bugs remain to be solved. :)