feat(frontpage): add JS OS Award 2026#4358
Conversation
✅ Deploy Preview for biomejs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
WalkthroughThe award banner now renders both 2024 and 2026 SVG images. The Changes
Sequence Diagram(s)Not applicable. Estimated code review effort: Low Related issues: None found Related PRs: None found Suggested labels: none Suggested reviewers: none 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/components/AwardBanner.astro`:
- Around line 9-10: The two banner images in AwardBanner.astro are sized
inconsistently because the 2024 Image uses an explicit width while the 2026
Image relies on its native SVG size. Update the AwardBanner Image usage so both
banner variants share the same sizing approach, either by adding a matching
width to banner2026 or by moving both to a shared CSS-based size in the same
component. Keep the change localized to the Image elements in AwardBanner so the
layout remains visually consistent between awards.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: e0edc635-a4c5-40d7-9b32-daee23e0d905
⛔ Files ignored due to path filters (1)
src/assets/JS_OSAward_2026_5_1.svgis excluded by!**/*.svg
📒 Files selected for processing (2)
src/components/AwardBanner.astrosrc/styles/_award.css
yanthomasdev
left a comment
There was a problem hiding this comment.
Thanks @Conaclos, just a small nit from me.
Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
|
Actually, adding the new class made it worse on mobile cc @yanthomasdev |
|
There is also an issue on desktop as indicated in my summary:
I think it is coming from the flexbloxes. |
|
@Conaclos If you add |
yanthomasdev
left a comment
There was a problem hiding this comment.
I'm sorry. Didn't notice at first it would break on mobile. This two suggestions will fix it on both desktop and mobile now.
Summary
This PR adds the image of the JS OS Award Productivity booster on our frontpage.
Using SVGO and svgoptimizer, I managed to reduce the SVG file size by 40% to 12 KB without any visible changes. This matches the size of the blurry WebP image of the JS OS Award 2024 (I guess it is automatically generated by Astro from the original PNG file).
EDIT: I have replaced the blurry image of the JS OS Award 2024 with an SVG version. I created this image by manually editing the 2026 version and replacing the last digit of the year. I have also sent an email to the JSNation team to request the original image.
I updated the CSS code in order to add spacing between the two images and arrange them vertically when there is not enough space. There is some inconsistency in the content alignment: the first image is vertically centred, while the second one is not. Any help is welcome.
See also the related resource PR.