Fix OAuth account connection hanging with "Background script not responding"#27
Draft
Copilot wants to merge 2 commits into
Draft
Fix OAuth account connection hanging with "Background script not responding"#27Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
… for token extraction, send errors on failure Agent-Logs-Url: https://github.com/biplobsd/yst/sessions/c6a810d9-4a0c-4c8e-9c6c-98c1674bc7f7 Co-authored-by: biplobsd <43641536+biplobsd@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix connecting account issue with Google authentication
Fix OAuth account connection hanging with "Background script not responding"
May 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After completing the Google OAuth flow, the extension would hang for ~30 seconds before showing "Background script not responding" — instead of connecting the account. The background service worker was silently returning in failure cases without notifying the options page, leaving it waiting indefinitely.
Changes
Missing early return on
isWorkingguard — error was sent but execution fell through and launched a second concurrent auth flow; addedreturnto exit cleanly.Silent returns replaced with explicit errors — two cases where the background returned without messaging the options page:
launchWebAuthFlowresolving toundefined(cancelled, blocked, or popup closed mid-flow)Fragile regex →
URLSearchParams— old regex/\#(?:access_token)\=([\S\s]*?)\&/required a trailing&, silently breaking ifaccess_tokenis the last fragment parameter (parameter ordering is not guaranteed by Google):