increase OpenFlow connection timeouts and make them configurable#488
Open
KanjiMonster wants to merge 2 commits into
Open
increase OpenFlow connection timeouts and make them configurable#488KanjiMonster wants to merge 2 commits into
KanjiMonster wants to merge 2 commits into
Conversation
OpenFlow says: "OpenFlow messages are processed out of order (see 6.2), and the processing of some requests by the switch may take a long time, therefore a controller must never terminate a connection because a request is taking too much time. An exception to that rule is for echo replies, a controller or a switch may terminate a connection if the reply for an echo request it sent takes too much time, however there must be a way to disable that feature and the timeout should be large enough to accommodate a wide variety of conditions." A maximum of 4 seconds (1 lifetime + 3 echo) is not much if the OpenFlow connection is conguested due to a large amount of messages to process, so double the echo timout. Since rofl-common also sends out echo requests on long-standing barrier requests, but barrier-requests inhibit processing messages until completed, also increase the lifetime check significantly to allow barrier_requests to take up to 16 seconds, not 4. This should significantly increase the stability of the OpenFlow connection under stress conditions. Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
Allow configuring two OpenFlow connection timeouts: * of_timeout_echo: timeout of sent echo requests * of_timeout_lifecheck: delay of sending echo requests if rx is idle This allows overriding the defaults in case the selected values are too tight. Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
KanjiMonster
force-pushed
the
jogo_timeouts
branch
from
304b41d to
2604ea9
Compare
Contributor
Author
|
Dropped the reference to the not existing |
b3n-l
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenFlow says:
A maximum of 4 seconds (1 lifetime + 3 echo) is not much if the OpenFlow connection is conguested due to a large amount of messages to process, so double the echo timout.
Since rofl-common also sends out echo requests on long-standing barrier requests, but barrier-requests inhibit processing messages until completed, also increase the lifetime check significantly to allow barrier_requests to take up to 16 seconds, not 4.
This should significantly increase the stability of the OpenFlow connection under stress conditions.
In case the chosen limits are insufficient or cause issues otherwise, make the values configurable.