More pools#1795
Open
mutatrum wants to merge 7 commits into
Open
Conversation
Collaborator
Collaborator
|
another nit, tho this might be better addressed in its own pr, the password field should be allowed to be empty |
Collaborator
Author
Can you explain, not sure what you mean here?
No, I'll pull them in line. |
Collaborator
see my screenshot, i added the pool count next to the "pool configurations" header. i think itd be nice for users to know how many can be stored uwu |
Collaborator
Author
|
3x done:
|
0xf0xx0
approved these changes
Jul 9, 2026
…more-pools # Conflicts: # main/nvs_config.c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

With SV2 having an Authoroty Pubkey, it's way more difficult to switch pools, just remembering the stratum URL and maybe a non-default port is not sufficient anymore. Therefore: pool profiles:
I'm not super happy with the code, it puts each pool config in a JSON in NVS. That's fairly clean, but the migration code is quite a lot. Updating a pool config through the API is now with a complete JSON, instead of per field. For most use-cases I think this is not a big issue, as with a maximum of 8 possible pool configurations there should ample space to put them all in.
A long-term roadmap for possible future pool/stratum PRs: