Skip to content

More pools#1795

Open
mutatrum wants to merge 7 commits into
bitaxeorg:masterfrom
mutatrum:more-pools
Open

More pools#1795
mutatrum wants to merge 7 commits into
bitaxeorg:masterfrom
mutatrum:more-pools

Conversation

@mutatrum

@mutatrum mutatrum commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

With SV2 having an Authoroty Pubkey, it's way more difficult to switch pools, just remembering the stratum URL and maybe a non-default port is not sufficient anymore. Therefore: pool profiles:

image

I'm not super happy with the code, it puts each pool config in a JSON in NVS. That's fairly clean, but the migration code is quite a lot. Updating a pool config through the API is now with a complete JSON, instead of per field. For most use-cases I think this is not a big issue, as with a maximum of 8 possible pool configurations there should ample space to put them all in.

A long-term roadmap for possible future pool/stratum PRs:

  • Change pool settings without restarts. Most of the code is already there with the pool coordinator task;
  • Priority queue instead of primary/fallback. Same here, the pool coordinator helps a lot with this;
  • Multi-pool mining with a ratio per pool.

@github-actions

github-actions Bot commented Jun 30, 2026

Copy link
Copy Markdown

Test Results

  2 files  ±0    2 suites  ±0   0s ⏱️ ±0s
103 tests ±0  103 ✅ ±0  0 💤 ±0  0 ❌ ±0 
105 runs  ±0  105 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit c9bbdb2. ± Comparison against base commit 55c7d8c.

♻️ This comment has been updated with latest results.

@0xf0xx0

0xf0xx0 commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

minor nit, should have a X/8 subtext next to the header imo
image

also bigger nit, will the buttons be rounded ui-wide? i kinda like it but it should be consistent x3

@0xf0xx0

0xf0xx0 commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

another nit, tho this might be better addressed in its own pr, the password field should be allowed to be empty

@mutatrum

mutatrum commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator Author

minor nit, should have a X/8 subtext next to the header imo

Can you explain, not sure what you mean here?

also bigger nit, will the buttons be rounded ui-wide? i kinda like it but it should be consistent x3

No, I'll pull them in line.

@0xf0xx0

0xf0xx0 commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

Can you explain, not sure what you mean here?

see my screenshot, i added the pool count next to the "pool configurations" header. i think itd be nice for users to know how many can be stored uwu

@mutatrum

mutatrum commented Jul 4, 2026

Copy link
Copy Markdown
Collaborator Author

3x done:

  • No rounded buttons;
  • Empty password allowed;
  • Configuration counter added.

…more-pools

# Conflicts:
#	main/nvs_config.c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants