fix: reduce sv2 minimum extranonce size from 6->2 bytes#1799
Open
0xf0xx0 wants to merge 1 commit into
Open
Conversation
0xf0xx0
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #1780
should this be extracted into a constant, and where? we could also use this value to create the
version-rolling.min-bit-countvalue for sv1 version rolling. i run a 2-byte extranonce myself, havent had any issues so im hoping this doesnt introduce any.E: also, this hard minimum should be documented somewhere...