Add GammaHex board support#1807
Open
benjamin-wilson wants to merge 11 commits into
Open
Conversation
# Conflicts: # main/device_config.h # main/global_state.h # main/main.c # main/screen.c # main/self_test/self_test.c # main/system.c # main/task_monitor.c # main/tasks/asic_result_task.c
mutatrum
reviewed
Jul 12, 2026
| BM1370_init_core_register_delay(); | ||
|
|
||
| // Present in the S21 XP init between core register control and analog mux. | ||
| _send_BM1370((TYPE_CMD | GROUP_ALL | CMD_WRITE), (uint8_t[]){0x00, 0x14, 0x00, 0x00, 0x00, 0xFF}, 6, BM1370_SERIALTX_DEBUG); |
Collaborator
There was a problem hiding this comment.
Why not do the delay inside _send_BM1370?
mutatrum
reviewed
Jul 12, 2026
| return ESP_ERR_INVALID_ARG; | ||
| } | ||
|
|
||
| if (state->DEVICE_CONFIG.family.id == GAMMA_610 || state->DEVICE_CONFIG.family.id == GAMMA_HEX) { |
Collaborator
There was a problem hiding this comment.
It would be cleaner if there is a disable_bap bool flag in device_config. This would be false by default so it only needs to be set to true on this model.
Collaborator
|
Not sure what to make of this, it's quite a code-dump. Some questions:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing