Add Copy address Peers Tab Context Menu Action#318
Merged
hebasto merged 1 commit intobitcoin-core:masterfrom Sep 12, 2021
Merged
Add Copy address Peers Tab Context Menu Action#318hebasto merged 1 commit intobitcoin-core:masterfrom
Copy address Peers Tab Context Menu Action#318hebasto merged 1 commit intobitcoin-core:masterfrom
Conversation
promag
reviewed
May 10, 2021
Contributor
promag
left a comment
promag
left a comment
There was a problem hiding this comment.
Concept ACK. But I'm not fond of the base commit "gui: add Direction column to peers tab" - I understand it simplifies this change.
Contributor
Author
Contributor
Author
|
updated from d6099b7 -> 85e0f95 (pr318.02 -> pr318.03) Changes:
|
Contributor
Author
|
updated from 85e0f95 -> 65d1d35 (pr318.03 -> pr318.04, diff)
|
luke-jr
reviewed
Jun 12, 2021
ghost
mentioned this pull request
Contributor
|
@jarolrod needs rebase, this is a cool change. |
Member
|
Concept ACK |
Co-authored-by: Jarol Rodriguez <jarolrod@tutanota.com>
jarolrod
force-pushed
the
copy-addr-peer
branch
from
65d1d35 to
3ec061d
Compare
Contributor
Author
shaavan
approved these changes
Sep 10, 2021
Contributor
shaavan
left a comment
shaavan
left a comment
There was a problem hiding this comment.
tACK 3ec061d
Tested on Ubuntu 20.04 (Using Qt version 5.12.8)
This PR adds the functionality to copy the address of a peer from the peertable itself. Tested this PR on Ubuntu 20.04. And I was able to observe the change working correctly.
| Master | PR |
|---|---|
 |
 |
I agree with the changes suggested in this PR. After #384 being merged, I think it is the next logical step to also having the functionality of copying the address of peer from peertable using the context menu action.
luke-jr
approved these changes
Sep 11, 2021
hebasto
approved these changes
Sep 12, 2021
|
|
||
| // create peer table context menu | ||
| peersTableContextMenu = new QMenu(this); | ||
| //: Context menu action to copy the address of a peer |
Member
There was a problem hiding this comment.
nit:
Suggested change
| //: Context menu action to copy the address of a peer | |
| //: Context menu action to copy the address of a peer. |
Member
|
Nice and useful change! |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Sep 13, 2021
… Action 3ec061d qt: Add "Copy address" item to the context menu in the Peers table (Hennadii Stepanov) Pull request description: Picking up #264 This adds a `Copy Address` context menu action to the `Peers Tab`. Based on the first commit of PR #317 so that we can use `Qt::DisplayRole` in the `copyEntryData` function. | Master | PR | | ----------- | ----------- | |  |  | ACKs for top commit: shaavan: tACK 3ec061d luke-jr: utACK 3ec061d hebasto: ACK 3ec061d, tested on Linux Mint 20.2 (Qt 5.12.8): Tree-SHA512: be0d7324592aae3928fa3cc522294f17226419fe8cbe3587df12a36bd4fa9c81bead377b13051e950b9a3fcd290b273861e70d6c76b75cdf76eaf58224b834cd
hebasto
added a commit
that referenced
this pull request
Sep 14, 2021
5cc783f qt: ensure translator comments end in full stop (Jarol Rodriguez) Pull request description: This is a follow-up to #318 which addresses this [nit](#318 (comment)) by addressing it globally. This ensures that all GUI translator comments end in a full stop. If a comment does not end in a full stop, a translator may think that the rest of the comment is being cut off. While here, add a colon to the word "see" for any comments touched which point to look at a link. ACKs for top commit: hebasto: ACK 5cc783f, I have reviewed the code and it looks OK, I agree it can be merged. shaavan: Code Review ACK 5cc783f Tree-SHA512: 67a1d56175c974e0af9b460fa44163f7ce139a7b81cfaf8ed2c0e7fb6d5120957c3135d96010aeb6229689468e36673fe9571b5a8c3e1c07e047aba1bd563444
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Sep 15, 2021
5cc783f qt: ensure translator comments end in full stop (Jarol Rodriguez) Pull request description: This is a follow-up to #318 which addresses this [nit](bitcoin-core/gui#318 (comment)) by addressing it globally. This ensures that all GUI translator comments end in a full stop. If a comment does not end in a full stop, a translator may think that the rest of the comment is being cut off. While here, add a colon to the word "see" for any comments touched which point to look at a link. ACKs for top commit: hebasto: ACK 5cc783f, I have reviewed the code and it looks OK, I agree it can be merged. shaavan: Code Review ACK 5cc783f Tree-SHA512: 67a1d56175c974e0af9b460fa44163f7ce139a7b81cfaf8ed2c0e7fb6d5120957c3135d96010aeb6229689468e36673fe9571b5a8c3e1c07e047aba1bd563444
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picking up #264
This adds a
Copy Addresscontext menu action to thePeers Tab.Based on the first commit of PR #317 so that we can use
Qt::DisplayRolein thecopyEntryDatafunction.