Connection Type Translator Comments#345
Merged
hebasto merged 1 commit intobitcoin-core:masterfrom Sep 29, 2021
Merged
Conversation
jarolrod
changed the title
jarolrod
force-pushed
the
connection-translator-comments
branch
from
0819d50 to
f5c2377
Compare
hebasto
reviewed
May 29, 2021
shaavan
reviewed
Jul 27, 2021
Contributor
shaavan
left a comment
shaavan
left a comment
There was a problem hiding this comment.
Concept ACK
I like the changes that are done here. They would very much help a translator to translate the strings with proper context correctly.
However, I want to make some suggestions here:
- In the Guiutil.cpp file in lines 675 to 677: It would help a translator if the meaning of inbound and outbound was briefly explained there.
- In the rpconsole.cpp file at line number 494: It should be mentioned that the Outbound peer connection is temporary, as mentioned in line 491
jarolrod
force-pushed
the
connection-translator-comments
branch
from
f5c2377 to
87b8129
Compare
jarolrod
force-pushed
the
connection-translator-comments
branch
from
87b8129 to
07adcbe
Compare
Talkless
approved these changes
Aug 11, 2021
Talkless
left a comment
Talkless
left a comment
There was a problem hiding this comment.
Code review ACK, comments looks good.
Member
Please insert a top commit hash :) |
hebasto
reviewed
Aug 11, 2021
jonatack
reviewed
Aug 11, 2021
Member
|
(Maybe update the translations in merged #317 per the writing style here, if relevant.) |
jarolrod
force-pushed
the
connection-translator-comments
branch
from
07adcbe to
8c13340
Compare
Contributor
Author
shaavan
reviewed
Sep 13, 2021
jarolrod
force-pushed
the
connection-translator-comments
branch
from
8c13340 to
371e2b9
Compare
Introduce Qt translator comments for connection types.
jarolrod
force-pushed
the
connection-translator-comments
branch
from
371e2b9 to
4832737
Compare
Member
|
Code review re-ACK 4832737 per |
hebasto
approved these changes
Sep 29, 2021
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Sep 29, 2021
4832737 qt: connection type translator comments (Jarol Rodriguez) Pull request description: This PR introduces Qt translator comments for `Connection Type` strings in `guiutil.cpp` as well as `rpcconsole.cpp`. This is an alternate implementation of the idea presented in the last three commits of #289. It is especially inspired by commit 842f4e834dfe5fd2786a5092f78ea28da1b36e4f. Per [Qt Dev Notes](https://github.com/bitcoin-core/bitcoin-devwiki/wiki/Developer-Notes-for-Qt-Code), it is better to not break up strings when not necessary. This way we preserve the full context for translators. ACKs for top commit: jonatack: Code review re-ACK 4832737 per `git diff 371e2b9 4832737`, changes are translator comment edits since my review yesterday (thank you for updating) hebasto: ACK 4832737 Tree-SHA512: 67e1741e10a2e30cde6d50d3293eec89f0b7641b34463865dc6909d2926cdcf33a7d8c1dc8055d2f85906ad2002cdaa594d37b184d16e2f06614b6c5ad00c982
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces Qt translator comments for
Connection Typestrings inguiutil.cppas well asrpcconsole.cpp.This is an alternate implementation of the idea presented in the last three commits of #289. It is especially inspired by commit 842f4e8.
Per Qt Dev Notes, it is better to not break up strings when not necessary. This way we preserve the full context for translators.