Honor inbound/outbound arrow prefix when sorting peer address column

[ghost]

Fixes #397

This re-establishes a functionality that was lost I guess since 0.21.

Peer address column sort with current master:
Peers 27 and 51 are sorted without honoring the connection direction.

Peer address column sort with this PR:
Peers 16 and 22 are sorted honoring the connection direction.

I would be grateful for implementation improvement suggestions.

[hebasto]

This re-establishes a functionality that was lost I guess since 0.21.

This is not true:

gui/src/qt/peertablemodel.cpp

Lines 26 to 27 in 4c097f9

	case PeerTableModel::Address:
	return pLeft->addrName.compare(pRight->addrName) < 0;

The implementation remains unchanged since v0.10.0 when it was introduced in bitcoin/bitcoin#4225.

---

UPDATE:

@wodry The arrows were added to addresses in your bitcoin/bitcoin#13537 (since v0.17.0).

[ghost]

OK thanks, then my guess was wrong and i did really not stumble upon this issue by chance. I thought it might have been lost with the new sortProxy.

[shaavan]

Tested on Ubuntu 20.04

The sorting of addresses in Master is purely lexicographical, irrespective of the direction of peer. This PR adds the functionality of taking the direction of peers as a prior consideration while sorting the addresses. The PR still sorts addresses in lexicographical order for the same direction peers.
I was able to compile and test the PR on Ubuntu 20.04 successfully.

Though I like the approach, since we want #317, it is not worth merging this PR because PR #317 would revert these changes.

[jarolrod]

The issue here is that the meaning of arrows are ambiguous, I am personally concept 0 on this in favor of #317. These PR's are essentially competing as #317 is just going to remove the arrows.

[hebasto]

Closing, as #317 has been merged.