Hide peers details by RandyMcMillan · Pull Request #505 · bitcoin-core/gui

RandyMcMillan · 2021-12-12T23:34:16Z

Add a close (X) button to the Peers Detail panel.
Reuse the same icon used in the Console Tab.
The close button deselects the peer highlighted
in the PeerTableView and hides the detail panel.

fixes #485

Co-authored-by: @w0xlt <w0xlt@users.noreply.github.com>

RandyMcMillan · 2021-12-12T23:35:32Z

RandyMcMillan · 2021-12-12T23:46:32Z

Tooltip message for better UX.

promag

We reuse the same icon used in the Console Tab for Gui consistency.

How so? One clears the console while the other unselects the peer.

promag · 2021-12-13T15:55:05Z

src/qt/rpcconsole.cpp

    ui->lineEdit->setMaxLength(16 * 1024 * 1024);
    ui->messagesWidget->installEventFilter(this);

+    connect(ui->hidePeersDetailButton, &QAbstractButton::clicked, [this] { hidePeersDetail(); });


Just

connect(ui->hidePeersDetailButton, &QAbstractButton::clicked, this, &RPCConsole::clearSelectedNode);

and ditch hidePeersDetails.

RandyMcMillan · 2021-12-13T16:40:19Z

Is there a better icon to use for a "close" action?

We don't have a "clear" icon in the repo - but something like this would be more appropriate for "clear console". So reusing the (X) icon seems prudent.

close file icon

luke-jr · 2021-12-13T22:23:43Z

Since it's possible to select multiple peers, but only one shows in the panel, perhaps leaving the "close" button is best, but don't have it deselect?

jarolrod

concept ACK

@luke-jr

Since it's possible to select multiple peers, but only one shows in the panel

Since #13 this is not possible. If multiple peers are selected, the panel will not show

src/qt/forms/debugwindow.ui

RandyMcMillan · 2021-12-14T22:06:48Z

I split this PR into 2 commits so others can experiment with adding the button to src/qt/forms/debugwindow.ui
Feel free to fetch this branch and experiment.

DrahtBot · 2021-12-30T10:52:42Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	pablomartin4btc, hebasto
Concept ACK	jarolrod
Stale ACK	rsafier, w0xlt, hernanmarino

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

No conflicts as of last run.

w0xlt

tACK 205c965 on Ubuntu 21.10 (Qt 5.15.2).

RandyMcMillan · 2022-01-23T23:03:15Z

@w0xlt any suggestions on reducing the diff in the .ui file would be appreciated - this is left unsquashed to allow for suggestions/variations

w0xlt · 2022-01-28T22:50:51Z

@RandyMcMillan

You can delete the last commit (git reset --hard 718589f) and apply the patch below.

diff --git a/src/qt/forms/debugwindow.ui b/src/qt/forms/debugwindow.ui
index 15e0d3fad..ad671b02e 100644
--- a/src/qt/forms/debugwindow.ui
+++ b/src/qt/forms/debugwindow.ui
@@ -984,6 +984,117 @@
            </size>
           </property>
           <layout class="QVBoxLayout" name="verticalLayout_8">
+            <item>
+              <layout class="QHBoxLayout" name="horizontalLayout_8">
+                <property name="topMargin">
+                  <number>0</number>
+                </property>
+                <property name="bottomMargin">
+                  <number>0</number>
+                </property>
+                <item>
+                  <widget class="QLabel" name="peerHeading">
+                  <property name="sizePolicy">
+                    <sizepolicy hsizetype="Preferred" vsizetype="Minimum">
+                    <horstretch>0</horstretch>
+                    <verstretch>0</verstretch>
+                    </sizepolicy>
+                  </property>
+                  <property name="minimumSize">
+                    <size>
+                    <width>0</width>
+                    <height>32</height>
+                    </size>
+                  </property>
+                  <property name="font">
+                    <font>
+                    <pointsize>10</pointsize>
+                    </font>
+                  </property>
+                  <property name="cursor">
+                    <cursorShape>IBeamCursor</cursorShape>
+                  </property>
+                  <property name="text">
+                    <string>Select a peer to view detailed information.</string>
+                  </property>
+                  <property name="alignment">
+                    <set>Qt::AlignHCenter|Qt::AlignTop</set>
+                  </property>
+                  <property name="wordWrap">
+                    <bool>true</bool>
+                  </property>
+                  <property name="textInteractionFlags">
+                    <set>Qt::LinksAccessibleByMouse|Qt::TextSelectableByKeyboard|Qt::TextSelectableByMouse</set>
+                  </property>
+                  </widget>
+                </item>
+                <item>
+                  <widget class="QWidget" name="hidePeersDetail" native="true">
+                    <property name="enabled">
+                      <bool>true</bool>
+                    </property>
+                    <property name="minimumSize">
+                      <size>
+                        <width>32</width>
+                        <height>32</height>
+                      </size>
+                    </property>
+                    <property name="maximumSize">
+                      <size>
+                        <width>32</width>
+                        <height>32</height>
+                      </size>
+                    </property>
+                    <widget class="QToolButton" name="hidePeersDetailButton">
+                      <property name="geometry">
+                        <rect>
+                          <x>0</x>
+                          <y>0</y>
+                          <width>32</width>
+                          <height>32</height>
+                        </rect>
+                      </property>
+                      <property name="minimumSize">
+                        <size>
+                          <width>32</width>
+                          <height>32</height>
+                        </size>
+                      </property>
+                      <property name="baseSize">
+                        <size>
+                          <width>32</width>
+                          <height>32</height>
+                        </size>
+                      </property>
+                      <property name="toolTip">
+                        <string>Hide Peers Detail</string>
+                      </property>
+                      <property name="layoutDirection">
+                        <enum>Qt::LeftToRight</enum>
+                      </property>
+                      <property name="text">
+                        <string />
+                      </property>
+                      <property name="icon">
+                        <iconset resource="../bitcoin.qrc">
+                          <normaloff>:/icons/remove</normaloff>
+                          :/icons/remove
+                        </iconset>
+                      </property>
+                      <property name="iconSize">
+                        <size>
+                          <width>22</width>
+                          <height>22</height>
+                        </size>
+                      </property>
+                      <property name="shortcut">
+                        <string>Ctrl+X</string>
+                      </property>
+                    </widget>
+                  </widget>
+                </item>
+              </layout>
+            </item>
            <item>
             <widget class="QLabel" name="peerHeading">
              <property name="sizePolicy">

RandyMcMillan · 2022-01-29T21:00:42Z

@w0xlt - applied the patch - thanks for the collaboration! attribution included in commit message.
I also implemented @promag's suggestion - much more prudent approach! - thanks!

RandyMcMillan · 2022-01-29T21:27:37Z

Commit: 2ae79d0

screen shot

rsafier · 2022-01-29T22:15:38Z

tACK 2ae79d0 on ARM M1/macOS/Monterey 12.1 (Qt 5.15.2)

w0xlt

reACK 2ae79d0

RandyMcMillan · 2022-01-31T16:24:26Z

To avoid re-adding diff junk to the debugwindow.ui file - I prefer to add translator comments in a follow up PR.

hebasto · 2022-10-26T16:06:06Z

@RandyMcMillan Still working on this PR?

DrahtBot · 2024-02-05T14:34:35Z

🤔 There hasn't been much activity lately and the CI seems to be failing.

If no one reviewed the current pull request by commit hash, a rebase can be considered. While the CI failure may be a false positive, the CI hasn't been running for some time, so there may be a real issue hiding as well. A rebase triggers the latest CI and makes sure that no silent merge conflicts have snuck in.

hebasto · 2024-02-11T22:12:50Z

This #505 (comment) still needs to be addressed.

RandyMcMillan · 2024-03-28T01:51:05Z

436ac4f duplicate ui element removed per @pablomartin4btc comment.

cc: @hebasto @w0xlt

pablomartin4btc

tACK 436ac4f

UI look & feel.

General view.
Tooltip.
Focus.

nit: not a blocker, please consider previous feedback regarding commit title length and meaningfulness, maybe gui: + this PR's title.

RandyMcMillan · 2024-03-28T19:23:34Z

Thanks I saw that - I can update the commit message...

DrahtBot · 2024-03-28T21:16:19Z

🚧 At least one of the CI tasks failed. Make sure to run all tests locally, according to the
documentation.

Possibly this is due to a silent merge conflict (the changes in this pull request being
incompatible with the current code in the target branch). If so, make sure to rebase on the latest
commit of the target branch.

Leave a comment here, if you need help tracking down a confusing failure.

_{Debug: https://github.com/bitcoin-core/gui/runs/23215732626}

@w0xlt

Add a close (X) button to the Peers Detail panel. Reuse the same icon used in the Console Tab. The close button deselects the peer highlighted in the PeerTableView and hides the detail panel. This PR addresses issue bitcoin-core#485: Co-authored-by: @w0xlt <w0xlt@users.noreply.github.com>

RandyMcMillan · 2024-04-09T18:32:44Z

41a1a86: update per previous suggestions

tACK 436ac4f

UI look & feel.
nit: not a blocker, please consider previous feedback regarding commit title length and meaningfulness, maybe gui: + this PR's title.

pablomartin4btc

re ACK 41a1a86

hebasto

ACK 41a1a86, tested on Ubuntu 23.10.

RandyMcMillan · 2024-08-16T12:08:42Z

thanks!

jarolrod added Feature UX All about "how to get things done" labels Dec 13, 2021

promag reviewed Dec 13, 2021

View reviewed changes

jarolrod reviewed Dec 14, 2021

View reviewed changes

src/qt/forms/debugwindow.ui Outdated Show resolved Hide resolved

src/qt/forms/debugwindow.ui Outdated Show resolved Hide resolved

RandyMcMillan force-pushed the 1639351552-issue-485 branch from 40ebab7 to 205c965 Compare December 14, 2021 21:39

RandyMcMillan marked this pull request as draft December 14, 2021 22:07

RandyMcMillan marked this pull request as ready for review December 22, 2021 01:28

DrahtBot mentioned this pull request Dec 30, 2021

Add abitlity to resize peerTable and banTable #457

Closed

DrahtBot mentioned this pull request Jan 21, 2022

Add address relay/processed/rate-limited fields to peer details #526

Merged

w0xlt approved these changes Jan 23, 2022

View reviewed changes

DrahtBot added the Needs rebase label Jan 28, 2022

RandyMcMillan changed the title ~~RPCConsole: add hidePeersDetail() button and functionality~~ RPCConsole: add hidePeersDetailButton and connect to RPCConsole::clearSelectedNode Jan 29, 2022

RandyMcMillan force-pushed the 1639351552-issue-485 branch from 205c965 to 2ae79d0 Compare January 29, 2022 21:09

DrahtBot removed the Needs rebase label Jan 29, 2022

w0xlt approved these changes Jan 30, 2022

View reviewed changes

RandyMcMillan marked this pull request as draft February 17, 2022 15:10

DrahtBot mentioned this pull request Oct 29, 2022

p2p: always provide CNodeStateStats and getpeerinfo/netinfo/gui updates bitcoin/bitcoin#25923

Closed

DrahtBot requested review from w0xlt and removed request for w0xlt September 20, 2023 15:44

DrahtBot added the CI failed label Oct 25, 2023

DrahtBot requested review from w0xlt and removed request for w0xlt February 11, 2024 22:12

RandyMcMillan force-pushed the 1639351552-issue-485 branch from d59363a to 436ac4f Compare March 28, 2024 01:47

RandyMcMillan requested review from hernanmarino, pablomartin4btc and promag March 28, 2024 01:51

DrahtBot removed the CI failed label Mar 28, 2024

pablomartin4btc approved these changes Mar 28, 2024

View reviewed changes

RandyMcMillan force-pushed the 1639351552-issue-485 branch from 436ac4f to 00000b8 Compare March 28, 2024 19:41

DrahtBot added the CI failed label Mar 28, 2024

RandyMcMillan force-pushed the 1639351552-issue-485 branch from 00000b8 to f722065 Compare March 29, 2024 00:17

DrahtBot removed the CI failed label Mar 29, 2024

RandyMcMillan changed the title ~~Hide Peers Detail Button~~ gui: Hide peers details Apr 9, 2024

RandyMcMillan force-pushed the 1639351552-issue-485 branch from f722065 to 41a1a86 Compare April 9, 2024 18:09

RandyMcMillan changed the title ~~gui: Hide peers details~~ Hide peers details Apr 9, 2024

pablomartin4btc approved these changes Apr 9, 2024

View reviewed changes

hebasto approved these changes Jul 30, 2024

View reviewed changes

hebasto merged commit d367a4e into bitcoin-core:master Jul 30, 2024

bitcoin-core locked and limited conversation to collaborators Aug 16, 2025

Comments

Conversation

RandyMcMillan commented Dec 12, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RandyMcMillan commented Dec 12, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RandyMcMillan commented Dec 12, 2021

Uh oh!

promag left a comment

Choose a reason for hiding this comment

Uh oh!

promag Dec 13, 2021

Choose a reason for hiding this comment

Uh oh!

RandyMcMillan commented Dec 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

luke-jr commented Dec 13, 2021

Uh oh!

jarolrod left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

RandyMcMillan commented Dec 14, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DrahtBot commented Dec 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews

Conflicts

Uh oh!

w0xlt left a comment

Choose a reason for hiding this comment

Uh oh!

RandyMcMillan commented Jan 23, 2022

Uh oh!

w0xlt commented Jan 28, 2022

Uh oh!

RandyMcMillan commented Jan 29, 2022

Uh oh!

RandyMcMillan commented Jan 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rsafier commented Jan 29, 2022

Uh oh!

w0xlt left a comment

Choose a reason for hiding this comment

Uh oh!

RandyMcMillan commented Jan 31, 2022

Uh oh!

hebasto commented Oct 26, 2022

Uh oh!

DrahtBot commented Feb 5, 2024

Uh oh!

hebasto commented Feb 11, 2024

Uh oh!

RandyMcMillan commented Mar 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pablomartin4btc left a comment

Choose a reason for hiding this comment

Uh oh!

RandyMcMillan commented Mar 28, 2024

Uh oh!

DrahtBot commented Mar 28, 2024

Uh oh!

RandyMcMillan commented Apr 9, 2024

Uh oh!

pablomartin4btc left a comment

Choose a reason for hiding this comment

Uh oh!

hebasto left a comment

Choose a reason for hiding this comment

Uh oh!

RandyMcMillan commented Aug 16, 2024

Uh oh!

Reviewers

RandyMcMillan commented Dec 12, 2021 •

edited

Loading

RandyMcMillan commented Dec 12, 2021 •

edited

Loading

RandyMcMillan commented Dec 13, 2021 •

edited

Loading

RandyMcMillan commented Dec 14, 2021 •

edited

Loading

DrahtBot commented Dec 30, 2021 •

edited

Loading

RandyMcMillan commented Jan 29, 2022 •

edited

Loading

RandyMcMillan commented Mar 28, 2024 •

edited

Loading