refactor: Drop unused QFrames in SendCoinsEntry#612
Merged
hebasto merged 4 commits intobitcoin-core:masterfrom Jun 21, 2022
Merged
refactor: Drop unused QFrames in SendCoinsEntry#612hebasto merged 4 commits intobitcoin-core:masterfrom
QFrames in SendCoinsEntry#612hebasto merged 4 commits intobitcoin-core:masterfrom
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced May 31, 2022
laanwj
reviewed
Jun 8, 2022
Member
|
Concept ACK, nice cleanup |
shaavan
approved these changes
Jun 11, 2022
Contributor
There was a problem hiding this comment.
ACK a57cd02
-
This PR does an excellent clean-up to
sendcoinentry.uifile by:- Removing no longer used code.
- Simplifying the widget type for the updated UI elements.
- Fixing indentations.
- Fixing the parent class for the
BitcoinAmountFieldwidget.
-
I was able to successfully compile and run this PR on Ubuntu 22.04 with
Qt version 5.15.3 -
I observed no functional or behavioral changes in the GUI.
As @laanwj rightly pointed out. The comment mentioning “Stacked widget” shall also be removed.
It is no longer needed to derive the `SendCoinsEntry` class from the `QStackedWidget` one.
hebasto
force-pushed
the
220530-sendcoins
branch
from
a57cd02 to
7ab72b9
Compare
w0xlt
approved these changes
Jun 13, 2022
shaavan
approved these changes
Jun 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
SendCoins_UnauthenticatedPaymentRequestandSendCoins_AuthenticatedPaymentRequestsub-QFrame's of theSendCoinsEntrywidget have been unused since bitcoin/bitcoin#17165.Removed all dead code. The resulted
SendCoinsEntrywidget has been simplified.