Skip to content

Comments

Release: Update src/qt/locale/bitcoin_en.xlf after string freeze#931

Merged
hebasto merged 1 commit intobitcoin-core:masterfrom
hebasto:260220-tr
Feb 21, 2026
Merged

Release: Update src/qt/locale/bitcoin_en.xlf after string freeze#931
hebasto merged 1 commit intobitcoin-core:masterfrom
hebasto:260220-tr

Conversation

@hebasto
Copy link
Member

@hebasto hebasto commented Feb 20, 2026

This PR follows our Release Process and implements the "Translation string freeze" step.

Steps to reproduce the diff on Linux:

$ cmake --preset dev-mode
$ cmake --build build_dev_mode --target translate
# Adjust new plurals manually according to https://github.com/bitcoin/bitcoin/blob/master/doc/translation_process.md#handling-plurals-in-source-files

@DrahtBot
Copy link
Contributor

DrahtBot commented Feb 20, 2026

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK MarnixCroes, achow101

If your review is incorrectly listed, please copy-paste <!--meta-tag:bot-skip--> into the comment that the bot should ignore.

@hebasto hebasto modified the milestones: 31, 31.0 Feb 20, 2026
@hebasto
Copy link
Member Author

hebasto commented Feb 20, 2026

Friendly ping @stickies-v @jarolrod @MarnixCroes :)

@hebasto hebasto changed the title Release: Update src/qt/locale/bitcoin_en.xlf after string freeze Release: Update src/qt/locale/bitcoin_en.xlf after string freeze Feb 20, 2026
Copy link

@jsarenik jsarenik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed this:

https://github.com/bitcoin-core/gui/pull/931/changes#diff-f1c140284e6cff64469345346fa556ff65ab02c80652afbf76d429ff904046c3R2322

Looks like a redundant line to me. See the one above (i.e. line 2321).

@hebasto
Copy link
Member Author

hebasto commented Feb 20, 2026

I just noticed this:

https://github.com/bitcoin-core/gui/pull/931/changes#diff-f1c140284e6cff64469345346fa556ff65ab02c80652afbf76d429ff904046c3R2322

Looks like a redundant line to me. See the one above (i.e. line 2321).

Line 2321 represents the singular form, while line 2322 represents the plural.

Copy link
Contributor

@MarnixCroes MarnixCroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ef98768

no diff

@achow101
Copy link
Member

ACK ef98768

@hebasto hebasto merged commit 6c8d628 into bitcoin-core:master Feb 21, 2026
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants