refactor: move parsing into its own module

[chuksys]

Closes #214

[f3r10]

Also, the standard for the commits is:

Also a small nitpick on commit naming (which is unconventional mostly personal preference, so feel free to ignore), generally we've been using the structure: scope/{action}, eg sim-ln/refactor, sim-cli/test followed by message.

[f3r10]

@chuksys the implementation of async closures also can be done in this PR #231 (comment).
It will be necessary to update the CI version to 1.85 so the CI checks can pass.

[carlaKC]

Not sure what's happening with the git history, but 00ffe3f shouldn't be in here - needs a rebase on main.

Happy for us to bump the CI version to take advantage of async closures - let's do that in a preparatory PR and then rebase this one on top of it.

[chuksys]

Not sure what's happening with the git history, but 00ffe3f shouldn't be in here - needs a rebase on main.

Happy for us to bump the CI version to take advantage of async closures - let's do that in a preparatory PR and then rebase this one on top of it.

Alright, will open a preparatory PR right away!

[chuksys]

Not sure what's happening with the git history, but 00ffe3f shouldn't be in here - needs a rebase on main.
Happy for us to bump the CI version to take advantage of async closures - let's do that in a preparatory PR and then rebase this one on top of it.

Alright, will open a preparatory PR right away!

PR #233

[carlaKC]

PR still has an unrelated commit in it: f1af8bb

Also needs to be rebased on #233 to get CI to pass.

[chuksys]

PR still has an unrelated commit in it: f1af8bb

Also needs to be rebased on #233 to get CI to pass.

I have removed the unrelated commit while rebasing on top of #233. Please let me know if I got it right and if there are any other fixes I need to make. Thanks.

[carlaKC]

There's still a merge commit in this PR and it needs to be rebased on main.

Please take some time to read up in interactive rebases and clean this up properly. If that means things take a bit longer, that's fine. Rather do it once and do it right than require multiple rounds of review on structural issues.

Please also run make check locally before pushing to make sure that clippy + formatting are correct.

[chuksys]

There's still a merge commit in this PR and it needs to be rebased on main.

Please take some time to read up in interactive rebases and clean this up properly. If that means things take a bit longer, that's fine. Rather do it once and do it right than require multiple rounds of review on structural issues.

Please also run make check locally before pushing to make sure that clippy + formatting are correct.

Okay will do. Thanks.

[f3r10]

Tested ACK tested with two cln nodes

@chuksys There are only a couple of minor issues then I think it will be ready to merge.

[f3r10]

Tested ACK

[chuksys]

Thanks so much @f3r10 for taking your time to thoroughly review this PR.

[carlaKC]

utACK, going to go ahead and merge this so that @f3r10 can get started on #215

[carlaKC]

nit: for future would prefer for this to be in its own commit.

[chuksys]

Thanks for all the feedback @carlaKC. They've been really helpful.