Skip to content

Comments

memusage fixes#139

Open
l0rinc wants to merge 17 commits intobitcoin-dev-tools:masterfrom
l0rinc:detached170
Open

memusage fixes#139
l0rinc wants to merge 17 commits intobitcoin-dev-tools:masterfrom
l0rinc:detached170

Conversation

@l0rinc
Copy link
Collaborator

@l0rinc l0rinc commented Feb 25, 2025

Revival of the memusage related commits from https://github.com/bitcoin/bitcoin/pull/31102/commits by @andrewtoth

@l0rinc l0rinc changed the title memusage: move MallocUsage into separate file memusage fixes Feb 25, 2025
@github-actions
Copy link

📊 Benchmark results for this run (13530535498) will be available at: https://bitcoin-dev-tools.github.io/benchcoin/results/pr-139/13530535498/index.html after the github pages "build and deployment" action has completed.
🚀 Speedups: mainnet-default-instrumented: -0.0%, mainnet-large-instrumented: -1.8%, mainnet-default-uninstrumented: -1.7%, mainnet-large-uninstrumented: -0.8%

@github-actions github-actions bot force-pushed the master branch 4 times, most recently from 607732d to e0dab54 Compare March 4, 2025 03:28
@github-actions github-actions bot force-pushed the master branch 6 times, most recently from 3b99594 to 4098c1c Compare March 10, 2025 03:20
willcl-ark and others added 4 commits March 17, 2025 19:39
this just creates needless rebasing. Remove it.
That way it becomes usable in other code like allocators/pool
That way all containers that use the pool have accurate memory tracking.

Add test to show memory is accurately tracked, even when nodes can't be allocated by the pool.
The more accurate memory estimation interferes shows that our memory estimation for Windows
is off, as the real allocated memory is much higher. This adapts the memusage_test test so it still
works with the more correct estimation.
@willcl-ark willcl-ark force-pushed the master branch 7 times, most recently from 3ae210c to 46bb65b Compare January 28, 2026 02:59
@willcl-ark willcl-ark force-pushed the master branch 6 times, most recently from 84c2b9e to 89c44f3 Compare February 4, 2026 03:28
@willcl-ark willcl-ark force-pushed the master branch 8 times, most recently from f56ba17 to 806bf25 Compare February 11, 2026 23:00
@willcl-ark willcl-ark force-pushed the master branch 6 times, most recently from b916666 to 764baeb Compare February 19, 2026 03:33
@willcl-ark willcl-ark force-pushed the master branch 3 times, most recently from d6be3ec to 1bc1f6c Compare February 22, 2026 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants