Open
Conversation
|
📊 Benchmark results for this run (13530535498) will be available at: https://bitcoin-dev-tools.github.io/benchcoin/results/pr-139/13530535498/index.html after the github pages "build and deployment" action has completed. |
607732d to
e0dab54
Compare
3b99594 to
4098c1c
Compare
Co-authored-by: David Gumberg <davidzgumberg@gmail.com> Co-authored-by: Lőrinc <pap.lorinc@gmail.com>
Co-authored-by: fanquake <fanquake@gmail.com>
This is still available in the testing repo: https://github.com/bitcoin-dev-tools/benchcoin-testing
4912c0c to
91b2e42
Compare
this just creates needless rebasing. Remove it.
That way it becomes usable in other code like allocators/pool
That way all containers that use the pool have accurate memory tracking. Add test to show memory is accurately tracked, even when nodes can't be allocated by the pool. The more accurate memory estimation interferes shows that our memory estimation for Windows is off, as the real allocated memory is much higher. This adapts the memusage_test test so it still works with the more correct estimation.
3ae210c to
46bb65b
Compare
84c2b9e to
89c44f3
Compare
f56ba17 to
806bf25
Compare
b916666 to
764baeb
Compare
d6be3ec to
1bc1f6c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revival of the memusage related commits from https://github.com/bitcoin/bitcoin/pull/31102/commits by @andrewtoth