Skip to content

Comments

LevelDB: avoid unnecessary memory copy#159

Draft
l0rinc wants to merge 15 commits intobitcoin-dev-tools:masterfrom
l0rinc:detached201
Draft

LevelDB: avoid unnecessary memory copy#159
l0rinc wants to merge 15 commits intobitcoin-dev-tools:masterfrom
l0rinc:detached201

Conversation

@l0rinc
Copy link
Collaborator

@l0rinc l0rinc commented Apr 4, 2025

google/leveldb#819

In the iterator loop, call meta->largest.DecodeFrom(key) every time is unnecessary, which will copy every key to meta's largest field. We just need to copy the last key after the iteration is done.

@l0rinc l0rinc marked this pull request as draft April 4, 2025 10:49
@l0rinc l0rinc changed the title avoid unnecessary memory copy LevelDB: avoid unnecessary memory copy Apr 4, 2025
@github-actions
Copy link

github-actions bot commented Apr 4, 2025

📊 Benchmark results for this run (14263715610) will be available at: https://bitcoin-dev-tools.github.io/benchcoin/results/pr-159/14263715610/index.html after the github pages "build and deployment" action has completed.
🚀 Speedups: mainnet-default-uninstrumented: 1.7%, mainnet-large-uninstrumented: -0.1%

@willcl-ark willcl-ark force-pushed the master branch 7 times, most recently from d216dc5 to 7f7e173 Compare October 29, 2025 02:02
@willcl-ark willcl-ark force-pushed the master branch 4 times, most recently from fc55a9b to ec1c504 Compare December 9, 2025 16:25
@willcl-ark willcl-ark force-pushed the master branch 7 times, most recently from 3ae210c to 46bb65b Compare January 28, 2026 02:59
@willcl-ark willcl-ark force-pushed the master branch 6 times, most recently from 84c2b9e to 89c44f3 Compare February 4, 2026 03:28
@willcl-ark willcl-ark force-pushed the master branch 8 times, most recently from f56ba17 to 806bf25 Compare February 11, 2026 23:00
@willcl-ark willcl-ark force-pushed the master branch 6 times, most recently from b916666 to 764baeb Compare February 19, 2026 03:33
@willcl-ark willcl-ark force-pushed the master branch 3 times, most recently from d6be3ec to 1bc1f6c Compare February 22, 2026 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants