net processing: Add ibd check before processing block for txdownloadman#175
Open
sedited wants to merge 2 commits intobitcoin-dev-tools:masterfrom
Open
net processing: Add ibd check before processing block for txdownloadman#175sedited wants to merge 2 commits intobitcoin-dev-tools:masterfrom
sedited wants to merge 2 commits intobitcoin-dev-tools:masterfrom
Conversation
|
📊 Benchmark results for this run (20207566058) will be available at: https://bitcoin-dev-tools.github.io/benchcoin/results/pr-175/20207566058/index.html after the github pages "build and deployment" action has completed. |
sedited
force-pushed
the
txdownloadman_ibd_check
branch
from
8da8ff3 to
42dc172
Compare
|
📊 Benchmark results for this run (20273254413) will be available at: https://bitcoin-dev-tools.github.io/benchcoin/results/pr-175/20273254413/index.html after the github pages "build and deployment" action has completed. |
willcl-ark
force-pushed
the
master
branch
3 times, most recently
from
44241cc to
da1434a
Compare
willcl-ark
force-pushed
the
master
branch
6 times, most recently
from
623391b to
201f2eb
Compare
willcl-ark
force-pushed
the
master
branch
11 times, most recently
from
9252506 to
aa46724
Compare
willcl-ark
force-pushed
the
master
branch
6 times, most recently
from
133f0db to
06af06f
Compare
sedited
force-pushed
the
txdownloadman_ibd_check
branch
from
42dc172 to
62383b7
Compare
Benchmark ResultsComparison to nightly master:
|
sedited
force-pushed
the
txdownloadman_ibd_check
branch
from
62383b7 to
c110908
Compare
Benchmark ResultsComparison to nightly master:
|
willcl-ark
force-pushed
the
master
branch
6 times, most recently
from
aee4563 to
3727c84
Compare
willcl-ark
force-pushed
the
master
branch
8 times, most recently
from
5e53bcf to
33b60af
Compare
willcl-ark
force-pushed
the
master
branch
5 times, most recently
from
764baeb to
aaf12e4
Compare
This documents existing behaviour before the change in the following commit: The bloom filter maintained by the txdownload manager tracks recently confirmed transasctions even during ibd. If a peer sends an INV once IBD is over it does not re-request them. Co-authored-by: sedited <seb.kung@gmail.com>
…downloadman This avoids wasting work on calculating bloom filters that aren't consumed during ibd and continuously re-calculated as now blocks get validated. Also update the functional test to document that transactions would now be requested again once out of IBD. Co-authored-by: Lőrinc <pap.lorinc@gmail.com>
sedited
force-pushed
the
txdownloadman_ibd_check
branch
from
c110908 to
ae19284
Compare
Benchmark ResultsComparison to nightly master:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just thought that this might stop triggering the destructor for the blocks on the scheduler thread, so making sure this does not introduce a regression.